Content-Length: 241426 | pFad | https://github.com/muxinc/mux-player-swift/pull/66

F5 ci: fix a misplaced 'wait' statement by daytime-em · Pull Request #66 · muxinc/mux-player-swift · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix a misplaced 'wait' statement #66

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

daytime-em
Copy link
Contributor

Quick followup for #64 . I swapped a wait and a command step in the pipeline yaml. This would make the jobs run in parallel, when there is a dependency relationship

This doesn't cause a problem in practice because our iOS queue has only 1 agent. But we shouldn't leave it like this

@daytime-em daytime-em requested a review from a team as a code owner January 16, 2025 19:09
@daytime-em daytime-em changed the title test: fix a misplaced 'wait' statement ci: fix a misplaced 'wait' statement Jan 16, 2025
Copy link
Contributor

@andrewjl-mux andrewjl-mux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great spot!

@daytime-em daytime-em merged commit d9356f4 into main Jan 16, 2025
1 check passed
@daytime-em daytime-em deleted the test/dropped-a-wait branch January 16, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/muxinc/mux-player-swift/pull/66

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy