Feature/i18n/refactoring and tests #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntation Feature/i18n/basic ssr implementation
StyleT
requested review from
oleh-momot and
nightnei
and removed request for
oleh-momot
nightnei
reviewed
Nov 27, 2020
| const i18n = registryConf.settings.i18n.enabled | ||
| ? new I18n(registryConf.settings.i18n, singleSpa, appErrorHandlerFactory) | ||
| : null; | ||
| const router = new Router(registryConf, state, i18n ? i18n.unlocalizeUrl : undefined, singleSpa); |
There was a problem hiding this comment.
it's not critical, but will be better to put undefined arguments as last argument or as optional inside object. and in this case we won't set undefiend here.
https://github.com/namecheap/ilc/pull/230/files#diff-318e72ee3c278cb96c1bb2130002e8a9bcdebd2042222be2a5284e589a1bb75eR204
nightnei
reviewed
Nov 27, 2020
| const preparationPromises = handlers.map(v => v.prepare(eventDetail)); | ||
|
|
||
| return Promise.allSettled(preparationPromises).then(results => { | ||
| for (let ii = 0; ii < results.length; ii++) { |
nightnei
reviewed
Nov 27, 2020
| return Promise.allSettled(executionPromises); | ||
| }).then(results => { | ||
| results | ||
| .map((v, i) => { |
There was a problem hiding this comment.
it's better to use reduce here
nightnei
reviewed
Nov 27, 2020
| @@ -0,0 +1,88 @@ | |||
| const _ = require('lodash'); | |||
There was a problem hiding this comment.
I propose to not use lodash if we can do it.
for example, here we can use deepmerge package.
nightnei
approved these changes
Nov 27, 2020
oleh-momot
approved these changes
Nov 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.