Fix/serialization #429
Merged
Fix/serialization #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzahor
force-pushed
the
fix/serialization
branch
from
cba3a3e to
954c042
Compare
mzahor
force-pushed
the
fix/serialization
branch
from
82d1df3 to
8ee7f0f
Compare
There was a problem hiding this comment.
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
Src/Notion.Client/Models/PropertyValue/RollupPropertyValue.cs:38
- [nitpick] Consider using a fully qualified name (DatePropertyValue.Date) for clarity and to avoid ambiguity with potential other Date types.
public Date Date { get; set; }
Src/Notion.Client/Models/PropertyValue/DateCustomConverter.cs:1
- The new custom date converter introduces important serialization logic that does not appear to have unit tests. Please add tests to ensure the conversion behaves as expected.
using System;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes several issues with serialization that we encountered in production.
I think it fixes #425 and #424
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: