Fix: date custom converter to serialize and deserialize ISO 8601 date and time #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use ISO 8601 date and time format * fix breaking test
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
Src/Notion.Client/Models/PropertyValue/DateCustomConverter.cs:45
- [nitpick] Consider using CultureInfo.InvariantCulture when formatting the date (e.g., value.Start.Value.ToString(startFormat, CultureInfo.InvariantCulture)) to ensure consistent serialization across different locales.
writer.WriteValue(value.Start.Value.ToString(startFormat));
Src/Notion.Client/Models/PropertyValue/DateCustomConverter.cs:52
- [nitpick] Consider using CultureInfo.InvariantCulture when formatting the 'end' date (e.g., value.End.Value.ToString(endFormat, CultureInfo.InvariantCulture)) for consistent behavior regardless of system culture.
writer.WriteValue(value.End.Value.ToString(endFormat));
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
Src/Notion.Client/Models/PropertyValue/DatePropertyValue.cs:51
- Verify that excluding the IncludeTime property from JSON serialization is intentional, as the custom converter handles the time formatting.
[JsonIgnore]
…nsistent parsing of ISO 8601 dates across different environments Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #425 & #429
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: