Content-Length: 293219 | pFad | https://github.com/python/cpython/issues/95656

B7 Enable sqlite extensions in the Windows build · Issue #95656 · python/cpython · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable sqlite extensions in the Windows build #95656

Closed
pfmoore opened this issue Aug 4, 2022 · 3 comments · Fixed by #95662
Closed

Enable sqlite extensions in the Windows build #95656

pfmoore opened this issue Aug 4, 2022 · 3 comments · Fixed by #95662
Assignees
@erlend-aasland
Labels
OS-windows topic-sqlite3 type-bug An unexpected behavior, bug, or error

Comments

@pfmoore
Copy link
Member

pfmoore commented Aug 4, 2022

Feature or enhancement

Enable SQLite extension loading in the Windows build (in the sqlite DLL shipped with Python, and in the stdlib sqlite3 module).

Pitch

At the moment, sqlite extensions are disabled at compile time - see the note in the docs. On Windows, though:

  1. We supply our own sqlite DLL, so we control the build options, and
  2. Users rarely build their own copy of Python.

So the reasons for not enabling extension loading don't really apply there, and conversely, people who want to use extensions cannot do so without limiting themselves to custom Python builds.

Previous discussion

See https://discuss.python.org/t/should-we-audit-enabling-loading-of-sqlite3-extensions-shared-libraries/8124/9
@pfmoore pfmoore added the type-feature A feature request or enhancement label Aug 4, 2022
@erlend-aasland erlend-aasland moved this to TODO: Feature in sqlite3 issues Aug 4, 2022
@erlend-aasland erlend-aasland self-assigned this Aug 4, 2022
@erlend-aasland
Copy link
Contributor

+1

I'll create a patch.

As I said on Discourse, I'd like to make it possible to enable extension loading via sqlite3_db_config(), but that is out of scope for this issue.

erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Aug 4, 2022
@erlend-aasland
pythongh-95656: Enable the sqlite3 load extension API in Windows build
26aaf40
@bedevere-bot bedevere-bot mentioned this issue Aug 4, 2022
Merged
@erlend-aasland erlend-aasland linked a pull request Aug 4, 2022 that will close this issue
gh-95656: Enable the sqlite3 load extension API in Windows build #95662
Merged
Repository owner moved this from TODO: Feature to Done in sqlite3 issues Aug 4, 2022
erlend-aasland added a commit that referenced this issue Aug 4, 2022
@erlend-aasland
gh-95656: Enable the sqlite3 load extension API in Windows build (#95662
6a5104f 
)
@bedevere-bot bedevere-bot mentioned this issue Aug 4, 2022
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 4, 2022
@erlend-aasland @miss-islington
pythongh-95656: Enable the sqlite3 load extension API in Windows build (
4a99d90 
pythonGH-95662)

(cherry picked from commit 6a5104f)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit to erlend-aasland/cpython that referenced this issue Aug 4, 2022
@erlend-aasland
[3.10] pythongh-95656: Enable the sqlite3 load extension API in Windo…
c9fe083 
…ws build (pythonGH-95662).

(cherry picked from commit 6a5104f)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@erlend-aasland erlend-aasland added type-bug An unexpected behavior, bug, or error and removed type-feature A feature request or enhancement labels Aug 4, 2022
@erlend-aasland
Copy link
Contributor

Repeating #95662 (comment):

Aha... no backport to 3.10 is needed. I changed the #ifdef guard in 3.11, while Christian and I were updating configure.ac. So... this means I broke this for Windows builds in 3.11.

FTR, broken in gh-29434.

miss-islington added a commit that referenced this issue Aug 4, 2022
@miss-islington @erlend-aasland
gh-95656: Enable the sqlite3 load extension API in Windows build (GH-…
6d83441 
…95662)

(cherry picked from commit 6a5104f)

Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@protonmail.com>
@pfmoore
Copy link
Member Author

pfmoore commented Aug 4, 2022

lol, I'd forgotten that by installing 3.11b5, it was now my default, so when I checked and it wasn't working I assumed that was normal, rather than a 3.11 regression.

Thanks for fixing it, and sorry for misreporting it!

iritkatriel pushed a commit to iritkatriel/cpython that referenced this issue Aug 11, 2022
@erlend-aasland @iritkatriel
pythongh-95656: Enable the sqlite3 load extension API in Windows build (
4e9e1d4 
python#95662)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erlend-aasland erlend-aasland

Labels
OS-windows topic-sqlite3 type-bug An unexpected behavior, bug, or error
Projects
sqlite3 issues
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-95656: Enable the sqlite3 load extension API in Windows build erlend-aasland/cpython
2 participants
@pfmoore @erlend-aasland








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/python/cpython/issues/95656

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy