Content-Length: 245542 | pFad | https://github.com/python/cpython/issues/98030

C6 socket: add missing TCP socket options from Linux · Issue #98030 · python/cpython · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

socket: add missing TCP socket options from Linux #98030

Closed
matttbe opened this issue Oct 7, 2022 · 1 comment
Closed

socket: add missing TCP socket options from Linux #98030

matttbe opened this issue Oct 7, 2022 · 1 comment
Labels
type-feature A feature request or enhancement

Comments

@matttbe
Copy link
Contributor

matttbe commented Oct 7, 2022

Feature or enhancement

socket modules already know most TCP socket options (TCP_NODELAY, TCP_MAXSEG, TCP_CORK, etc.) but not the recent ones.

Here is the complete list from the last Linux kernel version:
https://elixir.bootlin.com/linux/v6.0/source/include/uapi/linux/tcp.h#L91

Pitch

I noticed TCP_FASTOPEN_CONNECT was missing. I wanted to use it to write some quick tests for the kernel (MPTCP development). I was going to add only this one but while at it, best to add all the missing ones.

Linked PRs

@matttbe matttbe added the type-feature A feature request or enhancement label Oct 7, 2022
matttbe added a commit to matttbe/cpython that referenced this issue Oct 7, 2022
A few TCP socket options have been added to the Linux kernel these last
few years.

This commit adds all the ones available in Linux 6.0:

  https://elixir.bootlin.com/linux/v6.0/source/include/uapi/linux/tcp.h#L91

While at it, the TCP_FASTOPEN option has been moved lower in the list
just to keep the same order as in tcp.h to ease future synchronisations.

Please note that I initially wanted to get socket.TCP_FASTOPEN_CONNECT.
I was going to add only this one but while at it, here are all the
missing ones.

Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
matttbe added a commit to matttbe/cpython that referenced this issue Oct 10, 2022
A few TCP socket options have been added to the Linux kernel these last
few years.

This commit adds all the ones available in Linux 6.0:

  https://elixir.bootlin.com/linux/v6.0/source/include/uapi/linux/tcp.h#L91

While at it, the TCP_FASTOPEN option has been moved lower in the list
just to keep the same order as in tcp.h to ease future synchronisations.

Please note that I initially wanted to get socket.TCP_FASTOPEN_CONNECT.
I was going to add only this one but while at it, here are all the
missing ones.

Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
matttbe added a commit to matttbe/cpython that referenced this issue Oct 10, 2022
A few TCP socket options have been added to the Linux kernel these last
few years.

This commit adds all the ones available in Linux 6.0:

  https://elixir.bootlin.com/linux/v6.0/source/include/uapi/linux/tcp.h#L91

While at it, the TCP_FASTOPEN option has been moved lower in the list
just to keep the same order as in tcp.h to ease future synchronisations.

Please note that I initially wanted to get socket.TCP_FASTOPEN_CONNECT.
I was going to add only this one but while at it, here are all the
missing ones.

Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
matttbe added a commit to matttbe/cpython that referenced this issue Dec 7, 2022
A few TCP socket options have been added to the Linux kernel these last
few years.

This commit adds all the ones available in Linux 6.0:

  https://elixir.bootlin.com/linux/v6.0/source/include/uapi/linux/tcp.h#L91

While at it, the TCP_FASTOPEN option has been moved lower in the list
just to keep the same order as in tcp.h to ease future synchronisations.

Please note that I initially wanted to get socket.TCP_FASTOPEN_CONNECT.
I was going to add only this one but while at it, here are all the
missing ones.

Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
gpshead pushed a commit that referenced this issue Dec 8, 2022
A few TCP socket options have been added to the Linux kernel these last
few years.

This commit adds all the ones available in Linux 6.0:

  https://elixir.bootlin.com/linux/v6.0/source/include/uapi/linux/tcp.h#L91

While at it, the TCP_FASTOPEN option has been moved lower in the list
just to keep the same order as in tcp.h to ease future synchronisations.

Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
@gpshead
Copy link
Member

gpshead commented Dec 8, 2022

thanks!

@gpshead gpshead closed this as completed Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/python/cpython/issues/98030

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy