Content-Length: 270003 | pFad | https://github.com/python/cpython/pull/116369

1F gh-76785: Use PRId64 to Fix a Compiler Warning on Windows by ericsnowcurrently · Pull Request #116369 · python/cpython · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-76785: Use PRId64 to Fix a Compiler Warning on Windows #116369

Merged
merged 1 commit into from
Mar 5, 2024
Merged

gh-76785: Use PRId64 to Fix a Compiler Warning on Windows #116369

merged 1 commit into from
Mar 5, 2024

Conversation

ericsnowcurrently
Copy link
Member

@ericsnowcurrently ericsnowcurrently commented Mar 5, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Mar 5, 2024
Open
@ericsnowcurrently ericsnowcurrently enabled auto-merge (squash) March 5, 2024 17:48
@ericsnowcurrently ericsnowcurrently merged commit dab85e0 into python:main Mar 5, 2024
34 checks passed
@gvanrossum
Copy link
Member

Hey @ericsnowcurrently, on macOS I now (or still?) get a warning:

./Modules/_xxinterpqueuesmodule.c:762:22: warning: format specifies type 'long long' but the argument has type 'Py_ssize_t' (aka 'long') [-Wformat]
                qid, queue->items.count);
                     ^~~~~~~~~~~~~~~~~~

@AlexWaygood
Copy link
Member

Hey @ericsnowcurrently, on macOS I now (or still?) get a warning:

./Modules/_xxinterpqueuesmodule.c:762:22: warning: format specifies type 'long long' but the argument has type 'Py_ssize_t' (aka 'long') [-Wformat]
                qid, queue->items.count);
                     ^~~~~~~~~~~~~~~~~~

Nikita's already got a PR up to fix it: #116387

@ericsnowcurrently ericsnowcurrently deleted the fix-compiler-warnings branch March 6, 2024 00:13
This was referenced Mar 6, 2024
Closed
Merged
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@ericsnowcurrently @adorilson
pythongh-76785: Use PRId64 to Fix a Compiler Warning on Windows (pyth…
2e66c30 
…ongh-116369)

I accidentally introduced the warning in pythongh-116328.
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@ericsnowcurrently @diegorusso
pythongh-76785: Use PRId64 to Fix a Compiler Warning on Windows (pyth…
b50e523 
…ongh-116369)

I accidentally introduced the warning in pythongh-116328.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericsnowcurrently @gvanrossum @AlexWaygood








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/python/cpython/pull/116369

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy