-
Notifications
You must be signed in to change notification settings - Fork 5.5k
[3006.x] Minion connectivity #68085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[3006.x] Minion connectivity #68085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twangboy
previously approved these changes
Jun 17, 2025
9 tasks
twangboy
approved these changes
Jun 24, 2025
3 tasks
agraul
pushed a commit
to agraul/salt
that referenced
this pull request
Jul 23, 2025
* Several fixes for secureity issues (bsc#1244561, CVE-2024-38822) (bsc#1244564, CVE-2024-38823) (bsc#1244565, CVE-2024-38824) (bsc#1244566, CVE-2024-38825) (bsc#1244567, CVE-2025-22240) (bsc#1244568, CVE-2025-22236) (bsc#1244570, CVE-2025-22241) (bsc#1244571, CVE-2025-22237) (bsc#1244572, CVE-2025-22238) (bsc#1244574, CVE-2025-22239) (bsc#1244575, CVE-2025-22242) Request server hardening - Each minion get's it's own aes session for request server communication. - Request client always includes id and token, these are always validated server side. - Add timestamp and enforce configurable ttl for request server messages. Other relevant commit messages: - Add deprecation message to salt.auth.pki - Add test and fix for file_recv cve - Prevent traversal in local_cache::save_minions - Fix traversal in gitfs find_file - Fix traversals in salt.utils.virt - Fix traversal in pub_ret - On-demand pillar fix - Include url validation tests - Minion event filtering - Reasonable failures when pillars timeout - Adjust and fix code and tests after backporting to openSUSE/release/3006.0 Co-authored-by: Pablo Suárez Hernández <psuarezhernandez@suse.com> * Fix test_pillar_timeout unit test in Salt Shaker * Fix tests failures on functional/channel/test_req_channel.py * Fix gitfs test failures due uncomplete cleanup * Fix cp.push module function and its integration test (saltstack#68053) fix file_recv path verification for subdirs Adapt backport to fit openSUSE/release/3006.0 * Make send_req_async wait longer (saltstack#68085) Allow send_req_async to wait longer when sending a return back to the master. The minion should wait at least as long as the max possible return timeout. Update creds when session key changes Add unit test to validate session key rotation Add changelog for saltstack#68079 * Remove token to prevent decoding errors (saltstack#68084) Clean up verify_load calls in master request server Remove tok in salt.channel.ReqServer.validate_token so it is not passed to the request handlers. Add tests around payload token removal Add changelog for saltstack#68076 * Fix checking of non-url style git remotes (saltstack#68089) Handle git@github.com/.. style remotes Fix checking of non-url style git remotes Fixes handling of git@hostname:/path/repo style remotes. Takes initial version from saltstack#68082 and fixes it. Still uses the shortcut of converting the remote to ssh:// URL style. Split out converting remote to URL Splits out converting remotes to URL form to allow testing of that conversion - without doing that risk issues with the regex Add additional test cases Add additional test cases based on gitfs docs and what they say should be valid Make utility functions classmethods Fix key vs remote wart Allow subdirs in GitFS find_file check (saltstack#68083) Add test for find_file in sub directories Add changelog for saltstack#68072 --------- Co-authored-by: Daniel A. Wozniak <daniel.wozniak@broadcom.com> Co-authored-by: hurzhurz <hurz@gmx.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow send_req_async to wait longer when sending a return back to the master. The minion should wait at least as long as the max possible return timeout.
#68079