Content-Length: 256322 | pFad | https://github.com/starship/starship/pull/1527

B8 fix(test): do NOT quote argument values for mocked invocations by vladimyr · Pull Request #1527 · starship/starship · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(test): do NOT quote argument values for mocked invocations #1527

Merged
merged 2 commits into from
Aug 24, 2020

Conversation

vladimyr
Copy link
Member

Description

Thanks to @stefb69 (thanks again for your help and patience 💯 ) I realized I did a pretty stupid thing back in #1491
Quoting argument values in mocked invocations causes them to fail ultimately resulting in prompt defects (not showing version). So here I'm cleaning the mess I made 🙃

Motivation and Context

Fixes regressions introduced by #1491

Screenshots (if appropriate):

How Has This Been Tested?

  • I have tested using MacOS
  • I have tested using Linux
  • I have tested using Windows

Checklist:

  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

Sorry, something went wrong.

@andytom andytom merged commit faba2d1 into starship:master Aug 24, 2020
@andytom
Copy link
Member

andytom commented Aug 24, 2020

@vladimyr, thanks for the contribution sorry for taking so long to get this merged.

@vladimyr vladimyr deleted the fix-mocks branch August 24, 2020 18:10
chipbuster pushed a commit to chipbuster/starship that referenced this pull request Jan 14, 2021
…hip#1527)

Co-authored-by: Thomas O'Donnell <andytom@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/starship/starship/pull/1527

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy