fix(git_state) panic on interactive git rebase #1552
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr will fix a panic in the git_state module when doing a
git rebase
. It is possibly an edge case and might possibly only happen when the rebase only has one command.I've not done more testing regarding the cause but so far it has only triggered on rebase with one command thus I chose to return (1, 1) as progress.
Motivation and Context
Execute
git rebase -i
and put the editor in background (ctrl-z) or dropping to shell will result inScreenshots (if appropriate):
How Has This Been Tested?
I've recompiled
starship
usingcargo build --release --no-default-features
and verified it will resolve the panic.Checklist: