Content-Length: 261710 | pFad | https://github.com/sulu/SuluArticleBundle/pull/635

F7 Fix snippet selection by ramonbakker · Pull Request #635 · sulu/SuluArticleBundle · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix snippet selection #635

Merged

Conversation

ramonbakker
Copy link
Contributor

@ramonbakker ramonbakker commented Nov 28, 2022

The webspaceKey attribute is null in the previewer, but the key is available in the webspace attribute.

This fixes #190/#51.

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets fixes #190/#51
Related issues/PRs #190/#51
License MIT

What's in this PR?

This PR contains a bugfix for the problem described in ticket #190/#51.

@alexander-schranz alexander-schranz changed the base branch from 2.x to 2.5 April 12, 2023 22:45
@alexander-schranz alexander-schranz force-pushed the bugfix/snippet-selection-webspace-key branch from 0e20dfb to 18bf5a8 Compare April 12, 2023 22:46
@alexander-schranz alexander-schranz added the bug Error or unexpected behavior of already existing functionality label Apr 12, 2023
The webspaceKey attribute is null in the previewer, but the key is available in the webspace attribute.

This fixes sulu#51.
@alexander-schranz alexander-schranz force-pushed the bugfix/snippet-selection-webspace-key branch from 18bf5a8 to 0ff9fe4 Compare April 12, 2023 22:53
@alexander-schranz alexander-schranz merged commit 76cfd9b into sulu:2.5 Apr 12, 2023
@alexander-schranz
Copy link
Member

@ramonbakker thank you!

wachterjohannes pushed a commit to wachterjohannes/SuluArticleBundle that referenced this pull request Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Error or unexpected behavior of already existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Snippet content type not working with default true
2 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/sulu/SuluArticleBundle/pull/635

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy