Content-Length: 267969 | pFad | https://github.com/sveltia/sveltia-cms/issues/308

0D Bug: Closing image box in post editor opens link instead · Issue #308 · sveltia/sveltia-cms · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Closing image box in post editor opens link instead #308

Closed
RDjarbeng opened this issue Jan 15, 2025 · 6 comments
Closed

Bug: Closing image box in post editor opens link instead #308

RDjarbeng opened this issue Jan 15, 2025 · 6 comments
Assignees
@kyoshino
Labels
bug Something isn't working

Comments

@RDjarbeng
Copy link
Contributor

RDjarbeng commented Jan 15, 2025 •
edited
Loading

Current behaviour:
There is a bug in the markdown editor where, selecting the ✖️ icon to close the image editor when the image is added as a link opens the link. I have included a screen recording below.
https://github.com/user-attachments/assets/fc8e9658-18b3-4361-b360-ed62c3c5c19c
When you navigate back to the post, it is restored from a draft and the image editor is successfully deleted. I think the user shouldn't have to leave and return to the sveltia page for every image they close.

Expected behaviour: Clicking the close button should remove the image editor without opening another link

I am not sure why this happens. Also, this seems to happen when I paste text into the editor which contains image links.
@RDjarbeng RDjarbeng changed the title Closing image box in post editor opens link instead Bug: Closing image box in post editor opens link instead Jan 15, 2025
@kyoshino
Copy link
Member

Will check.

@kyoshino kyoshino self-assigned this Jan 15, 2025
@kyoshino kyoshino added the bug Something isn't working label Jan 15, 2025
@kyoshino
Copy link
Member

kyoshino commented Jan 16, 2025 •
edited
Loading

This was indeed due to a pasted linked image. v0.53.6 added a quick workaround, but currently there is no way to edit such non-text links, and the Markdown syntax will be broken when switching to raw text mode. I’ll figure out how to fix these issues later.

Thanks for caching the bug anyway!

@RDjarbeng
Copy link
Contributor Author

Thanks for the workaround

@kyoshino
Copy link
Member

Found this, will implement in Sveltia:

kyoshino added a commit that referenced this issue Jan 17, 2025
@kyoshino
Allow to edit link on image in Markdown editor
6c3f83e 
Follow up #308
@kyoshino
Copy link
Member

v0.54.0 added support for editing the link on an image.

@RDjarbeng
Copy link
Contributor Author

Thanks so much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyoshino kyoshino

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kyoshino @RDjarbeng








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/sveltia/sveltia-cms/issues/308

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy