Remove useless uniqid in tempnam calls in tests
#57614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @GromNaN. |
Note that this usage is not safe in the general case: The filename might be reused between the call to For tests it's probably fine, but for production code it would requiring handling the |
This was referenced Jul 16, 2025
nicolas-grekas
added a commit
that referenced
this pull request
Jul 22, 2025
…ate snapshots anymore (KevinVanSonsbeek) This PR was merged into the 7.2 branch. Discussion ---------- [Config] Fix GeneratedConfigTest not being able to generate snapshots anymore | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | Fix #61139 | License | MIT PR #57614 Removed multiple uses of `uniqid`. In the specific PR changes were made to the GeneratedConfigTest, to change how the directory was built for the config. This inadvertedly broke the generating of snapshot files, due to the outputDir being changed to a by reference argument, and always overwriting the value to a temp dir. (While the snapshot files should not be written to a temp dir) Commits ------- 8e8daf1 bugfix(#61139): Only generate an outputDir if none is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For creating a temporary directory, I use
tempnamthen remove the file and create the directory with the same name.