Content-Length: 242105 | pFad | https://github.com/thedmd/imgui-node-editor/issues/173

1B Object containers in the EditorContext are not properly cleaned up · Issue #173 · thedmd/imgui-node-editor · GitHub
Skip to content

Object containers in the EditorContext are not properly cleaned up #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
shamilatesoglu opened this issue Aug 1, 2022 · 2 comments
Closed

Object containers in the EditorContext are not properly cleaned up #173

shamilatesoglu opened this issue Aug 1, 2022 · 2 comments
Assignees
@thedmd
Labels
bug

Comments

@shamilatesoglu
Copy link

The object containers m_Nodes, m_Pins, m_Links inside EditorContext are not properly cleaned after a node or link is deleted. As long as the same EditorContext is used, these containers continue to inflate. So when a node is deleted, if a same ID is used to create another node, the FindNode function returns the previous node object with the settings of the previous node. In groups, for example, this problem causes it to have the previous group's size when a new group with the same ID is created (after the first one is deleted).
@thedmd
Copy link
Owner

thedmd commented Aug 12, 2022

Delete operation indeed should remove objects from the lists. Will work on that.
Thanks for reporting.

@thedmd thedmd self-assigned this Aug 12, 2022
@thedmd thedmd added the bug label Aug 12, 2022
thedmd added a commit that referenced this issue Aug 21, 2022
@thedmd
Delete operation on node/link will remove internal object (#173)
4a966d6
@thedmd
Copy link
Owner

thedmd commented Aug 21, 2022

Objects are now deleted from internal vectors when removed using delete action.

@thedmd thedmd closed this as completed Aug 21, 2022
thedmd added a commit that referenced this issue Aug 21, 2022
@thedmd
Delete operation on node/link will remove internal object (#173) (fixup)
ba622a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thedmd thedmd

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thedmd @shamilatesoglu








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/thedmd/imgui-node-editor/issues/173

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy