Block dropping internal compressed chunks with drop_chunk()
#7695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@erimatnor, @akuzm: please review this pull request.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7695 +/- ##
==========================================
+ Coverage 80.06% 81.93% +1.86%
==========================================
Files 190 247 +57
Lines 37181 45425 +8244
Branches 9450 11354 +1904
==========================================
+ Hits 29770 37219 +7449
- Misses 2997 3741 +744
- Partials 4414 4465 +51 ☔ View full report in Codecov by Sentry. |
zilder
force-pushed
the
zilder/drop_chunk_compressed
branch
from
a47ff5c to
ea24f09
Compare
svenklemm
approved these changes
Feb 18, 2025
akuzm
approved these changes
Feb 18, 2025
Dropping internal compressed chunks is blocked on DDL level, but is still possible with `_timescaledb_functions.drop_chunk` function. This patch adds a simple check to prevent that.
zilder
force-pushed
the
zilder/drop_chunk_compressed
branch
from
ea24f09 to
5b6a8ee
Compare
fabriziomello
added
the
force-auto-backport
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Feb 19, 2025
This release contains performance improvements and bug fixes since the 2.18.1 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#7686 Potential wrong aggregation result when using vectorized aggregation with hash grouping in reverse order * timescale#7694 Fix ExplainHook breaking call chain * timescale#7695 Block dropping internal compressed chunks with `drop_chunk()` * timescale#7711 License error when using hypercore handler * timescale#7712 Respect other extensions' ExecutorStart hooks **Thanks** * @davidmehren and @jflambert for reporting an issue with extension hooks * @jflambert for reporting a bug with license errors shown in autovacuum
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Feb 19, 2025
This release contains performance improvements and bug fixes since the 2.18.1 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#7686 Potential wrong aggregation result when using vectorized aggregation with hash grouping in reverse order * timescale#7694 Fix ExplainHook breaking call chain * timescale#7695 Block dropping internal compressed chunks with `drop_chunk()` * timescale#7711 License error when using hypercore handler * timescale#7712 Respect other extensions' ExecutorStart hooks **Thanks** * @davidmehren and @jflambert for reporting an issue with extension hooks * @jflambert for reporting a bug with license errors shown in autovacuum
Merged
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Feb 19, 2025
This release contains performance improvements and bug fixes since the 2.18.1 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#7686 Potential wrong aggregation result when using vectorized aggregation with hash grouping in reverse order * timescale#7694 Fix ExplainHook breaking call chain * timescale#7695 Block dropping internal compressed chunks with `drop_chunk()` * timescale#7711 License error when using hypercore handler * timescale#7712 Respect other extensions' ExecutorStart hooks **Thanks** * @davidmehren and @jflambert for reporting an issue with extension hooks * @jflambert for reporting a bug with license errors shown in autovacuum
svenklemm
added a commit
that referenced
this pull request
Feb 19, 2025
This release contains performance improvements and bug fixes since the 2.18.1 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * #7686 Potential wrong aggregation result when using vectorized aggregation with hash grouping in reverse order * #7694 Fix ExplainHook breaking call chain * #7695 Block dropping internal compressed chunks with `drop_chunk()` * #7711 License error when using hypercore handler * #7712 Respect other extensions' ExecutorStart hooks **Thanks** * @davidmehren and @jflambert for reporting an issue with extension hooks * @jflambert for reporting a bug with license errors shown in autovacuum
svenklemm
added a commit
to svenklemm/timescaledb
that referenced
this pull request
Feb 19, 2025
This release contains performance improvements and bug fixes since the 2.18.1 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * timescale#7686 Potential wrong aggregation result when using vectorized aggregation with hash grouping in reverse order * timescale#7694 Fix ExplainHook breaking call chain * timescale#7695 Block dropping internal compressed chunks with `drop_chunk()` * timescale#7711 License error when using hypercore handler * timescale#7712 Respect other extensions' ExecutorStart hooks **Thanks** * @davidmehren and @jflambert for reporting an issue with extension hooks * @jflambert for reporting a bug with license errors shown in autovacuum
Merged
svenklemm
added a commit
that referenced
this pull request
Feb 19, 2025
This release contains performance improvements and bug fixes since the 2.18.1 release. We recommend that you upgrade at the next available opportunity. **Bugfixes** * #7686 Potential wrong aggregation result when using vectorized aggregation with hash grouping in reverse order * #7694 Fix ExplainHook breaking call chain * #7695 Block dropping internal compressed chunks with `drop_chunk()` * #7711 License error when using hypercore handler * #7712 Respect other extensions' ExecutorStart hooks **Thanks** * @davidmehren and @jflambert for reporting an issue with extension hooks * @jflambert for reporting a bug with license errors shown in autovacuum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on this SDC
Dropping internal compressed chunks is blocked on DDL level (with process utility hook), but is still possible with
_timescaledb_functions.drop_chunkfunction. This patch adds a simple check to prevent that.