Content-Length: 508742 | pFad | https://github.com/tokio-rs/tokio/pull/6975

76 allow getting task dump backtraces in a programmatic format by arielb1 · Pull Request #6975 · tokio-rs/tokio · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow getting task dump backtraces in a programmatic format #6975

Merged
merged 10 commits into from
Dec 9, 2024

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Nov 14, 2024

This PR creates structs that allow dumping backtraces in a programmatic format, for example JSON. A JSON serializer is not natively included to avoid creating a Tokio dependency on one, but serialization can be done by customers.

Fixes #6309.

@github-actions github-actions bot added R-loom-current-thread Run loom current-thread tests on this PR R-loom-multi-thread Run loom multi-thread tests on this PR R-loom-multi-thread-alt Run loom multi-thread alt tests on this PR labels Nov 14, 2024
@arielb1 arielb1 force-pushed the programmatic-backtraces branch 3 times, most recently from df04fc7 to ede6e06 Compare November 14, 2024 18:00
@arielb1
Copy link
Contributor Author

arielb1 commented Nov 19, 2024

What is this waiting for?

@arielb1
Copy link
Contributor Author

arielb1 commented Nov 20, 2024

So @Darksonn is busy these days. Could @mox692 please review this?

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-taskdump --cfg tokio_taskdump labels Nov 21, 2024
Copy link
Member

@mox692 mox692 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I left high level questions about suggested apis.

tokio/src/runtime/dump.rs Show resolved Hide resolved
tokio/src/runtime/dump.rs Outdated Show resolved Hide resolved
tokio/src/runtime/dump.rs Outdated Show resolved Hide resolved
@arielb1 arielb1 force-pushed the programmatic-backtraces branch 4 times, most recently from d96b28a to 3f9d94f Compare November 25, 2024 13:44
tokio/src/runtime/dump.rs Outdated Show resolved Hide resolved
tokio/src/runtime/dump.rs Outdated Show resolved Hide resolved
tokio/src/runtime/dump.rs Outdated Show resolved Hide resolved
@arielb1 arielb1 force-pushed the programmatic-backtraces branch from 3f9d94f to 0ab0985 Compare November 30, 2024 16:57
@arielb1 arielb1 force-pushed the programmatic-backtraces branch from 0ab0985 to 7aaf2e7 Compare November 30, 2024 16:57
@arielb1
Copy link
Contributor Author

arielb1 commented Nov 30, 2024

addressed comments

@Darksonn Darksonn requested a review from mox692 December 4, 2024 09:27
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks fine. Just two things:

tokio/src/runtime/dump.rs Outdated Show resolved Hide resolved
tokio/src/runtime/dump.rs Outdated Show resolved Hide resolved
tokio/src/runtime/dump.rs Outdated Show resolved Hide resolved
tokio/src/runtime/dump.rs Outdated Show resolved Hide resolved
@arielb1 arielb1 force-pushed the programmatic-backtraces branch from 38717f9 to 6dc30e3 Compare December 4, 2024 15:42
tokio/src/runtime/dump.rs Outdated Show resolved Hide resolved
@arielb1 arielb1 force-pushed the programmatic-backtraces branch from de26d9b to b028387 Compare December 4, 2024 16:08
Copy link
Member

@mox692 mox692 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor doc related suggestions, but otherwise looks good to me.

tokio/src/runtime/dump.rs Outdated Show resolved Hide resolved
tokio/src/runtime/dump.rs Outdated Show resolved Hide resolved
tokio/src/runtime/dump.rs Outdated Show resolved Hide resolved
tokio/src/runtime/dump.rs Outdated Show resolved Hide resolved
@arielb1
Copy link
Contributor Author

arielb1 commented Dec 5, 2024

committed @mox692 doc suggestions. Can someone approve?

@arielb1 arielb1 force-pushed the programmatic-backtraces branch from ba09a06 to 295f0f6 Compare December 5, 2024 10:47
Co-authored-by: Motoyuki Kimura <moymoymox@gmail.com>
@arielb1 arielb1 force-pushed the programmatic-backtraces branch from 295f0f6 to f579f98 Compare December 5, 2024 11:02
Copy link
Member

@mox692 mox692 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@arielb1
Copy link
Contributor Author

arielb1 commented Dec 6, 2024

Can you merge or are we waiting for @Darksonn ?

@mox692 mox692 merged commit 48e07a6 into tokio-rs:master Dec 9, 2024
87 checks passed
@mox692
Copy link
Member

mox692 commented Dec 9, 2024

Merged, thank you @arielb1.

kodiakhq bot pushed a commit to pdylanross/fatigue that referenced this pull request Jan 13, 2025
⚠️  Dependabot is rebasing this PR ⚠️
Rebasing might not happen immediately, so don't worry if this takes some time.
Note: if you make any changes to this PR yourself, they will take precedence over the rebase.

Bumps tokio from 1.42.0 to 1.43.0.

Release notes
Sourced from tokio's releases.

Tokio v1.43.0
1.43.0 (Jan 8th, 2025)
Added

net: add UdpSocket::peek methods (#7068)
net: add support for Haiku OS (#7042)
process: add Command::into_std() (#7014)
signal: add SignalKind::info on illumos (#6995)
signal: add support for realtime signals on illumos (#7029)

Fixed

io: don't call set_len before initializing vector in Blocking (#7054)
macros: suppress clippy::needless_return in #[tokio::main] (#6874)
runtime: fix thread parking on WebAssembly (#7041)

Changes

chore: use unsync loads for unsync_load (#7073)
io: use Buf::put_bytes in Repeat read impl (#7055)
task: drop the join waker of a task eagerly (#6986)

Changes to unstable APIs

metrics: improve flexibility of H2Histogram Configuration (#6963)
taskdump: add accessor methods for backtrace (#6975)

Documented

io: clarify ReadBuf::uninit allows initialized buffers as well (#7053)
net: fix ambiguity in TcpStream::try_write_vectored docs (#7067)
runtime: fix LocalRuntime doc links (#7074)
sync: extend documentation for watch::Receiver::wait_for (#7038)
sync: fix typos in OnceCell docs (#7047)

#6874: tokio-rs/tokio#6874
#6963: tokio-rs/tokio#6963
#6975: tokio-rs/tokio#6975
#6986: tokio-rs/tokio#6986
#6995: tokio-rs/tokio#6995
#7014: tokio-rs/tokio#7014
#7029: tokio-rs/tokio#7029
#7038: tokio-rs/tokio#7038
#7041: tokio-rs/tokio#7041
#7042: tokio-rs/tokio#7042
#7047: tokio-rs/tokio#7047
#7053: tokio-rs/tokio#7053
#7054: tokio-rs/tokio#7054
#7055: tokio-rs/tokio#7055


... (truncated)


Commits

5f3296d chore: prepare Tokio v1.43.0 (#7079)
cc974a6 chore: prepare tokio-macros v2.5.0 (#7078)
15495fd metrics: improve flexibility of H2Histogram Configuration (#6963)
ad41834 io: don't call set_len before initializing vector in Blocking (#7054)
bd3e857 runtime: move is_join_waker_set assertion in unset_waker (#7072)
15f7366 runtime: fix LocalRuntime doc links (#7074)
fd2048d ci: split miri jobs into unit and integration tests (#7071)
e8f3915 chore: use unsync loads for unsync_load (#7073)
67f1277 net: fix ambiguity in TcpStream::try_write_vectored docs (#7067)
463502c io: clarify ReadBuf::uninit allows initialized buffers as well (#7053)
Additional commits viewable in compare view




Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-taskdump --cfg tokio_taskdump R-loom-current-thread Run loom current-thread tests on this PR R-loom-multi-thread Run loom multi-thread tests on this PR R-loom-multi-thread-alt Run loom multi-thread alt tests on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support an API to extract backtrace information from taskdump
3 participants








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/tokio-rs/tokio/pull/6975

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy