feat: Enable json request body #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbansla
commented
Jun 26, 2023
| @@ -18,7 +18,7 @@ public class Converter { | |||
| * @param map map to convert | |||
| * @return converted JSON string | |||
| */ | |||
| public static String mapToJson(final Map<String, Object> map) { | |||
| public static String mapToJson(final Map<String, ? extends Object> map) { | |||
There was a problem hiding this comment.
This line of code is added to support all object serialization which has a value of type Object or any object.
sbansla
commented
Jun 26, 2023
| for (String value : entry.getValue()) { | ||
| builder.addParameter(entry.getKey(), value); | ||
| // TODO: It will be removed after one RC Release. | ||
| if (request.getContentType() == null) request.setContentType(Enum.ContentType.FORM_URLENCODED); |
There was a problem hiding this comment.
java code does not have content type set. It will throw Null pointer exception on test. This line of code will be removed after one RC release.
kridai
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Adding support for handling json request body.
Checklist
If you have questions, please file a support ticket, or create a GitHub Issue in this repository.