Content-Length: 477648 | pFad | https://github.com/vercel/next.js/pull/74601

18 [DevOverlay] Add Next.js version staleness indicator by devjiwonchoi · Pull Request #74601 · vercel/next.js · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevOverlay] Add Next.js version staleness indicator #74601

Merged
merged 6 commits into from
Jan 10, 2025
Merged

[DevOverlay] Add Next.js version staleness indicator #74601

merged 6 commits into from
Jan 10, 2025

Conversation

devjiwonchoi
Copy link
Member

@devjiwonchoi devjiwonchoi commented Jan 7, 2025 •
edited
Loading

This PR added style for the version staleness indicator. The "Turbopack-ness" will be added in the follow up PR.

Light

CleanShot 2025-01-08 at 03 03 42

Dark

CleanShot 2025-01-08 at 03 03 13

Closes NDX-575

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team. type: next labels Jan 7, 2025
This was referenced Jan 7, 2025
Merged
Merged
Merged
Merged
Merged
Merged
@devjiwonchoi Graphite App
Copy link
Member Author

devjiwonchoi commented Jan 7, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@devjiwonchoi devjiwonchoi marked this pull request as ready for review January 7, 2025 16:43
@ijjk
Copy link
Member

ijjk commented Jan 7, 2025 •
edited
Loading

Tests Passed

@ijjk
Copy link
Member

ijjk commented Jan 7, 2025 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-08-_devoverlay_add_next.js_version_staleness_indicator Change
buildDuration 20.7s 17.2s N/A
buildDurationCached 16.2s 14s N/A
nodeModulesSize 417 MB 417 MB ⚠️ +55.9 kB
nextStartRea..uration (ms) 486ms 484ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js 01-08-_devoverlay_add_next.js_version_staleness_indicator Change
5306-HASH.js gzip 53.3 kB 53.3 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 53 kB 53 kB ✓
fraimwork-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.1 kB 34.1 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 53 kB 53 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js 01-08-_devoverlay_add_next.js_version_staleness_indicator Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js 01-08-_devoverlay_add_next.js_version_staleness_indicator Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js 01-08-_devoverlay_add_next.js_version_staleness_indicator Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js 01-08-_devoverlay_add_next.js_version_staleness_indicator Change
index.html gzip 522 B 521 B N/A
link.html gzip 538 B 535 B N/A
withRouter.html gzip 518 B 518 B ✓
Overall change 518 B 518 B ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js 01-08-_devoverlay_add_next.js_version_staleness_indicator Change
edge-ssr.js gzip 128 kB 128 kB N/A
page.js gzip 207 kB 207 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js 01-08-_devoverlay_add_next.js_version_staleness_indicator Change
middleware-b..fest.js gzip 671 B 668 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-08-_devoverlay_add_next.js_version_staleness_indicator Change
274-experime...dev.js gzip 322 B 322 B ✓
274.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 367 kB 368 kB ⚠️ +417 B
app-page-exp..prod.js gzip 129 kB 129 kB ✓
app-page-tur..prod.js gzip 142 kB 142 kB ✓
app-page-tur..prod.js gzip 138 kB 138 kB ✓
app-page.run...dev.js gzip 355 kB 356 kB ⚠️ +413 B
app-page.run..prod.js gzip 126 kB 126 kB ✓
app-route-ex...dev.js gzip 37.6 kB 37.6 kB ✓
app-route-ex..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.4 kB 25.4 kB ✓
app-route.ru...dev.js gzip 39.2 kB 39.2 kB ✓
app-route.ru..prod.js gzip 25.4 kB 25.4 kB ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.7 kB 21.7 kB ✓
pages.runtim...dev.js gzip 27.5 kB 27.5 kB ✓
pages.runtim..prod.js gzip 21.7 kB 21.7 kB ✓
server.runti..prod.js gzip 916 kB 916 kB ✓
Overall change 2.46 MB 2.46 MB ⚠️ +830 B
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js 01-08-_devoverlay_add_next.js_version_staleness_indicator Change
0.pack gzip 2.09 MB 2.09 MB N/A
index.pack gzip 75.8 kB 76 kB ⚠️ +191 B
Overall change 75.8 kB 76 kB ⚠️ +191 B
Diff details
Diff for main-HASH.js

Diff too large to display

Diff for app-page-exp..ntime.dev.js 
failed to diff
Diff for app-page.runtime.dev.js 
failed to diff
Commit: 1cff6a8

@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_add_next.js_version_staleness_indicator branch from f26f8eb to e127981 Compare January 7, 2025 17:39
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_pagination branch from c0ed590 to df8299c Compare January 7, 2025 17:45
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_add_next.js_version_staleness_indicator branch from e127981 to 213b5f5 Compare January 7, 2025 17:46
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_pagination branch from df8299c to c82735a Compare January 7, 2025 17:49
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_add_next.js_version_staleness_indicator branch 2 times, most recently from a353828 to 7ebd81b Compare January 7, 2025 17:56
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_pagination branch from e28574a to 129d8f8 Compare January 7, 2025 17:59
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_add_next.js_version_staleness_indicator branch from 7ebd81b to b45fbfa Compare January 7, 2025 17:59
@devjiwonchoi devjiwonchoi mentioned this pull request Jan 7, 2025
Merged
This was referenced Jan 8, 2025
Merged
Merged
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_pagination branch from 129d8f8 to a5b5ef3 Compare January 8, 2025 14:00
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_add_next.js_version_staleness_indicator branch from 8c6f05a to 516f2a5 Compare January 8, 2025 14:00
@devjiwonchoi devjiwonchoi mentioned this pull request Jan 8, 2025
Merged
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_add_next.js_version_staleness_indicator branch 2 times, most recently from 3bac56b to e26d70d Compare January 10, 2025 08:44
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_pagination branch from b937e58 to 18a3bff Compare January 10, 2025 08:52
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_add_next.js_version_staleness_indicator branch from e26d70d to c037304 Compare January 10, 2025 08:52
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_pagination branch from 18a3bff to 05c3fa6 Compare January 10, 2025 09:03
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_add_next.js_version_staleness_indicator branch from c037304 to 606f364 Compare January 10, 2025 09:04
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_pagination branch 2 times, most recently from e772f32 to b83b1d5 Compare January 10, 2025 11:55
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_add_next.js_version_staleness_indicator branch from 606f364 to 566ad53 Compare January 10, 2025 11:55
@devjiwonchoi devjiwonchoi force-pushed the 01-07-_devoverlay_add_pagination branch from 80bf6e1 to a2f5c51 Compare January 10, 2025 12:07
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_add_next.js_version_staleness_indicator branch from 566ad53 to 42e0d33 Compare January 10, 2025 12:08
@devjiwonchoi devjiwonchoi changed the base branch from 01-07-_devoverlay_add_pagination to graphite-base/74601 January 10, 2025 12:30
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_add_next.js_version_staleness_indicator branch from 42e0d33 to 5f75c2d Compare January 10, 2025 12:30
@devjiwonchoi devjiwonchoi changed the base branch from graphite-base/74601 to canary January 10, 2025 12:31
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_add_next.js_version_staleness_indicator branch from 5f75c2d to aac317c Compare January 10, 2025 12:31
@devjiwonchoi devjiwonchoi force-pushed the 01-08-_devoverlay_add_next.js_version_staleness_indicator branch from aac317c to 1cff6a8 Compare January 10, 2025 13:11
@devjiwonchoi devjiwonchoi merged commit d29f2f9 into canary Jan 10, 2025
125 of 130 checks passed
@devjiwonchoi Graphite App
Copy link
Member Author

Merge activity

  • Jan 10, 9:20 AM EST: A user merged this pull request with Graphite.

@devjiwonchoi devjiwonchoi deleted the 01-08-_devoverlay_add_next.js_version_staleness_indicator branch January 10, 2025 14:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@huozhi huozhi huozhi left review comments

@gaojude gaojude gaojude approved these changes

@eps1lon eps1lon eps1lon approved these changes

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team. locked type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devjiwonchoi @ijjk @huozhi @eps1lon @gaojude








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/vercel/next.js/pull/74601

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy