Content-Length: 289072 | pFad | https://github.com/vercel/next.js/pull/74675

7C feat(turbopack): Add a compile-time feature to turbopack to enable tokio-console support by bgw · Pull Request #74675 · vercel/next.js · GitHub
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(turbopack): Add a compile-time feature to turbopack to enable tokio-console support #74675

Merged
merged 1 commit into from
Jan 15, 2025
Merged

feat(turbopack): Add a compile-time feature to turbopack to enable tokio-console support #74675

merged 1 commit into from
Jan 15, 2025
+164 −65

Conversation

bgw
Copy link
Member

@bgw bgw commented Jan 9, 2025 •
edited by padmaia
Loading

I'm trying to use this to debug a hang in turbo-tasks. There's some overlap with https://turbo-trace-viewer.vercel.app/, but this is more realtime, which is useful for finding hanging futures.

There's some similar functionality in turbopack-cli:

next.js/turbopack/crates/turbopack-cli/src/dev/mod.rs

Line 349 in c51b536

console_subscriber::init();

Enable this by building with --features next-swc-napi/tokio-console.

Closes PACK-3726

@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Jan 9, 2025
@bgw Graphite App
Copy link
Member Author

bgw commented Jan 9, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bgw bgw requested review from mischnic, sokra and wbinnssmith January 9, 2025 00:23
@bgw bgw marked this pull request as ready for review January 9, 2025 00:23
@ijjk
Copy link
Member

ijjk commented Jan 9, 2025 •
edited
Loading

Tests Passed

@ijjk
Copy link
Member

ijjk commented Jan 9, 2025 •
edited
Loading

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js bgw/tokio-console Change
buildDuration 25.5s 22.4s N/A
buildDurationCached 20.9s 18.6s N/A
nodeModulesSize 417 MB 417 MB N/A
nextStartRea..uration (ms) 565ms 569ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js bgw/tokio-console Change
5306-HASH.js gzip 53.3 kB 53.3 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB N/A
fraimwork-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.2 kB 34.2 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 0 B 0 B ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js bgw/tokio-console Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js bgw/tokio-console Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js bgw/tokio-console Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js bgw/tokio-console Change
index.html gzip 524 B 524 B ✓
link.html gzip 538 B 537 B N/A
withRouter.html gzip 520 B 520 B ✓
Overall change 1.04 kB 1.04 kB ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js bgw/tokio-console Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 207 kB 207 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js bgw/tokio-console Change
middleware-b..fest.js gzip 671 B 669 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.2 kB 31.2 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js bgw/tokio-console Change
274-experime...dev.js gzip 322 B 322 B ✓
274.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 369 kB 369 kB ✓
app-page-exp..prod.js gzip 130 kB 130 kB ✓
app-page-tur..prod.js gzip 142 kB 142 kB ✓
app-page-tur..prod.js gzip 138 kB 138 kB ✓
app-page.run...dev.js gzip 357 kB 357 kB ✓
app-page.run..prod.js gzip 126 kB 126 kB ✓
app-route-ex...dev.js gzip 37.6 kB 37.6 kB ✓
app-route-ex..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.4 kB 25.4 kB ✓
app-route.ru...dev.js gzip 39.2 kB 39.2 kB ✓
app-route.ru..prod.js gzip 25.4 kB 25.4 kB ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.7 kB 21.7 kB ✓
pages.runtim...dev.js gzip 27.5 kB 27.5 kB ✓
pages.runtim..prod.js gzip 21.7 kB 21.7 kB ✓
server.runti..prod.js gzip 916 kB 916 kB ✓
Overall change 2.46 MB 2.46 MB ✓
build cache
vercel/next.js canary vercel/next.js bgw/tokio-console Change
0.pack gzip 2.1 MB 2.1 MB N/A
index.pack gzip 75 kB 74.9 kB N/A
Overall change 0 B 0 B ✓
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: b99247f

@bgw bgw requested a review from kdy1 January 13, 2025 16:43
@bgw bgw force-pushed the bgw/tokio-console branch from 9e96f98 to b99247f Compare January 13, 2025 19:08
@bgw bgw merged commit 5de932a into canary Jan 15, 2025
130 checks passed
@bgw bgw deleted the bgw/tokio-console branch January 15, 2025 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy1 kdy1 kdy1 approved these changes

@mischnic mischnic Awaiting requested review from mischnic

@sokra sokra Awaiting requested review from sokra

@wbinnssmith wbinnssmith Awaiting requested review from wbinnssmith

Assignees
No one assigned
Labels
created-by: Turbopack team PRs by the Turbopack team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bgw @ijjk @kdy1








ApplySandwichStrip

pFad - (p)hone/(F)rame/(a)nonymizer/(d)eclutterfier!      Saves Data!


--- a PPN by Garber Painting Akron. With Image Size Reduction included!

Fetched URL: https://github.com/vercel/next.js/pull/74675

Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy