signal: add support for realtime signals on illumos #7029
Conversation
sunshowers
force-pushed
the
realtime-illumos
branch
from
d3cdf49 to
45c64ff
Compare
|
Hmm, I guess qemu (on some targets?) doesn't support realtime signals? Thoughts on whether/how to keep the test? |
|
@sunshowers there's CI jobs failing right now. I can review this once CI passes. I'm operating under the assumption here that you have tested this on Illumos (you probably have a better test environment for that OS than I do 🤪). |
See my question in #7029 (comment). It looks like this may be a deficiency in qemu cross-testing exposed by my test, and I would love advice on whether and how to retain the test. (Yeah, I've tested on illumos, as mentioned in the PR summary.) |
|
Sorry, I missed that. You can just disable it on the broken targets for now. |
|
Thanks -- is there a general way to determine in the test suite whether a test is being run under qemu? The issue isn't with the targets, but with the fact that qemu is involved. |
|
Nothing in the harness afaik, and otomh I am not sure what the best way to determine if in qemu is. |
|
All right, I think I see what's going on. Looking at it more deeply on my local machine -- while cross-testing from x86_64-unknown-linux-gnu to aarch64-unknown-linux-gnu, It looks like this is documented in https://wiki.qemu.org/ChangeLog/9.2#signals as being expected. 28 realtime signals are available, which matches the range 34..=61. The documentation says the last 4 signals are invalid, but that's assuming there are 32 signals -- in reality, qemu only returns 31 signals, so the last 3 are invalid. Based on this, I think I'm just going to cap it at SIGRTMIN + 27 (inclusive, i.e. 28 signals). |
The API was added in libc 0.2.168. Also added a test for realtime signals.
sunshowers
force-pushed
the
realtime-illumos
branch
from
45c64ff to
1e9157b
Compare
|
All right, let's see how this goes. |
|
Looks like the tests passed! The one failure looks unrelated/flaky maybe. |
|
i'm kicking the failing jobs |
|
@sunshowers merged 🎉! |
⚠️ Dependabot is rebasing this PR⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. Bumps tokio from 1.42.0 to 1.43.0. Release notes Sourced from tokio's releases. Tokio v1.43.0 1.43.0 (Jan 8th, 2025) Added net: add UdpSocket::peek methods (#7068) net: add support for Haiku OS (#7042) process: add Command::into_std() (#7014) signal: add SignalKind::info on illumos (#6995) signal: add support for realtime signals on illumos (#7029) Fixed io: don't call set_len before initializing vector in Blocking (#7054) macros: suppress clippy::needless_return in #[tokio::main] (#6874) runtime: fix thread parking on WebAssembly (#7041) Changes chore: use unsync loads for unsync_load (#7073) io: use Buf::put_bytes in Repeat read impl (#7055) task: drop the join waker of a task eagerly (#6986) Changes to unstable APIs metrics: improve flexibility of H2Histogram Configuration (#6963) taskdump: add accessor methods for backtrace (#6975) Documented io: clarify ReadBuf::uninit allows initialized buffers as well (#7053) net: fix ambiguity in TcpStream::try_write_vectored docs (#7067) runtime: fix LocalRuntime doc links (#7074) sync: extend documentation for watch::Receiver::wait_for (#7038) sync: fix typos in OnceCell docs (#7047) #6874: tokio-rs/tokio#6874 #6963: tokio-rs/tokio#6963 #6975: tokio-rs/tokio#6975 #6986: tokio-rs/tokio#6986 #6995: tokio-rs/tokio#6995 #7014: tokio-rs/tokio#7014 #7029: tokio-rs/tokio#7029 #7038: tokio-rs/tokio#7038 #7041: tokio-rs/tokio#7041 #7042: tokio-rs/tokio#7042 #7047: tokio-rs/tokio#7047 #7053: tokio-rs/tokio#7053 #7054: tokio-rs/tokio#7054 #7055: tokio-rs/tokio#7055 ... (truncated) Commits 5f3296d chore: prepare Tokio v1.43.0 (#7079) cc974a6 chore: prepare tokio-macros v2.5.0 (#7078) 15495fd metrics: improve flexibility of H2Histogram Configuration (#6963) ad41834 io: don't call set_len before initializing vector in Blocking (#7054) bd3e857 runtime: move is_join_waker_set assertion in unset_waker (#7072) 15f7366 runtime: fix LocalRuntime doc links (#7074) fd2048d ci: split miri jobs into unit and integration tests (#7071) e8f3915 chore: use unsync loads for unsync_load (#7073) 67f1277 net: fix ambiguity in TcpStream::try_write_vectored docs (#7067) 463502c io: clarify ReadBuf::uninit allows initialized buffers as well (#7053) Additional commits viewable in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Motivation
Completing the work started in #6995 -- the
SIGRTMINandSIGRTMAXAPIs were added for illumos in libc 0.2.168. They were also added for Solaris, but out of caution I don't want to turn this on until someone verifies that realtime signals work as expected there.Also added a test for realtime signals which can be used while porting to other platforms in the future. The test passes successfully on both Linux and illumos (tested locally).