gh-126332: Fix pyrepl crash for double ctrl-z in line overflow - #126650
Merged
Conversation
eendebakpt
requested review from
ambv,
lysnikolaou and
pablogsal
as code owners
November 10, 2024 19:41
vstinner
reviewed
Jan 19, 2025
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
Would it be possible to add a new Lib/test/test_pyrepl/test_utils.py file and add tests on wlen() and str_width() functions?
Member
I think we should do this in a separate PR. @eendebakpt do you want to open a PR for that? |
|
Thanks @eendebakpt for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 21, 2025
…ythonGH-126650) (cherry picked from commit d147e5e) Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
|
GH-129154 is a backport of this pull request to the 3.13 branch. |
pablogsal
pushed a commit
that referenced
this pull request
Jan 21, 2025
…GH-126650) (#129154) gh-126332: Fix pyrepl crash for double ctrl-z in line overflow (GH-126650) (cherry picked from commit d147e5e) Co-authored-by: Pieter Eendebak <pieter.eendebak@gmail.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Contributor
Author
|
@pablogsal I added some tests in #129325 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes:
str_widthmethod instead of thewlenmethod. Both of these are not documented, so I am not sure whether one location should be preferred over the other.