gh-132983: Minor fixes and clean up for the _zstd module - #134930
Merged
Conversation
serhiy-storchaka
added
skip news
needs backport to 3.14
13 tasks
emmatyping
reviewed
May 30, 2025
emmatyping
left a comment
emmatyping
left a comment
Member
There was a problem hiding this comment.
One question and one concern, but the rest looks good! Thank you for the improvements :)
AA-Turner
reviewed
May 31, 2025
Comment on lines
-510
to
-515
| if (!PyType_Check(c_parameter_type) || !PyType_Check(d_parameter_type)) { | ||
| PyErr_SetString(PyExc_ValueError, | ||
| "The two arguments should be CompressionParameter and " | ||
| "DecompressionParameter types."); | ||
| return NULL; | ||
| } |
Member
There was a problem hiding this comment.
Sanity check on removing the type checks here?
Member
There was a problem hiding this comment.
The type checks are already handled by argument clinic, so these are actually redundant.
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
emmatyping
approved these changes
May 31, 2025
emmatyping
left a comment
emmatyping
left a comment
Member
There was a problem hiding this comment.
The changes look good! One minor wording suggestion but great otherwise. Thank you!
Co-authored-by: Emma Smith <emma@emmatyping.dev>
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 1, 2025
…nGH-134930) (cherry picked from commit b595237) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-134998 is a backport of this pull request to the 3.14 branch. |
Member
Author
|
Thank you @AA-Turner and @emmatyping for your review. |
serhiy-storchaka
added a commit
that referenced
this pull request
Jun 1, 2025
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.