fix(core): resolve plugin manager promises in sequence instead of parallel

Ovidiu Barabula · Ovidiu Barabula · commit d9630fc0c41f · 2018-04-10T14:21:29.000+03:00
Configuration questionnaire were trying to run all at the same time, which meant only one
questionnaire configuration was being saved. Promise.all() waits for the promises to be resolved in
parallel. Switching to a 'for, of' loop with await makes sure all the questionnaire are started in
sequence.
diff --git a/src/config-wizard/index.ts b/src/config-wizard/index.ts
@@ -252,9 +252,9 @@ function ConfigWizard(
 
         // Merge configuration defaults with answers from questionnaire
         const newAnswers = { ...currentDefaults, ...answers };
+        const stringAnswers = JSON.stringify(newAnswers, null, 2);
 
-        logger.info(`Your '${questionnaire.namespace}' configuration:`);
-        console.log(JSON.stringify(newAnswers, null, 2));
+        logger.info(`Your '${questionnaire.namespace}' configuration: \n${stringAnswers}`);
         return await setConfiguration(questionnaire.namespace, newAnswers);
       }
 
@@ -275,7 +275,7 @@ function ConfigWizard(
       throw new Error(ERRORS.QUESTIONNARE_NAMESPACE_DOESNT_EXIST);
     }
 
-    logger.info(`Configure '${namespace}'`);
+    logger.info(`Configure '${namespace}':`);
     return await inquirer.prompt(questionnaires[namespace]);
   }
 
diff --git a/src/plugin-manager/index.ts b/src/plugin-manager/index.ts
@@ -145,12 +145,11 @@ function PluginManager(taskManager: TaskManager, configWizard: IConfigWizard): P
   async function use(...plugins: PluginsArray): Promise<void> {
     // Parse plugins array and get installable plugins
     const installablePlugins = await parsePlugins(plugins);
+
     // Install each plugin
-    await Promise.all(
-      installablePlugins.map(
-        async (plugin: Plugin) => await install(plugin),
-      ),
-    );
+    for (const plugin of installablePlugins) {
+      await install(plugin);
+    }
   }
 
 

Original file line number	Diff line number	Diff line change
`@@ -252,9 +252,9 @@ function ConfigWizard(`
`252`	`252`
`253`	`253`	`// Merge configuration defaults with answers from questionnaire`
`254`	`254`	`const newAnswers = { ...currentDefaults, ...answers };`
	`255`	`+ const stringAnswers = JSON.stringify(newAnswers, null, 2);`
`255`	`256`
`256`		- logger.info(`Your '${questionnaire.namespace}' configuration:`);
`257`		`- console.log(JSON.stringify(newAnswers, null, 2));`
	`257`	+ logger.info(`Your '${questionnaire.namespace}' configuration: \n${stringAnswers}`);
`258`	`258`	`return await setConfiguration(questionnaire.namespace, newAnswers);`
`259`	`259`	`}`
`260`	`260`
`@@ -275,7 +275,7 @@ function ConfigWizard(`
`275`	`275`	`throw new Error(ERRORS.QUESTIONNARE_NAMESPACE_DOESNT_EXIST);`
`276`	`276`	`}`
`277`	`277`
`278`		- logger.info(`Configure '${namespace}'`);
	`278`	+ logger.info(`Configure '${namespace}':`);
`279`	`279`	`return await inquirer.prompt(questionnaires[namespace]);`
`280`	`280`	`}`
`281`	`281`