Skip to content

Add support for H.265 codec verification #1644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

seydx
Copy link
Contributor

@seydx seydx commented Mar 11, 2025

This pull request includes updates to the VideoRTC class in the www/video-rtc.js file to enhance codec support checking. The most important changes are the addition of a new method to check for H.265 support and the modification of codec priority assignment logic.

Enhancements to codec support checking:

  • www/video-rtc.js: Added a new static method isH265Supported to check if H.265/HEVC codecs are supported by the browser.
  • www/video-rtc.js: Updated the condition for assigning msePriority for 'hvc1.' codecs to include a check using the new isH265Supported method.

@felipecrs
Copy link
Contributor

Chrome 136 is probably going to support H.265 in WebRTC by default. Is this PR needed for functioning with Chrome?

@felipecrs
Copy link
Contributor

Chrome 136 is probably going to support H.265 in WebRTC by default. Is this PR needed for functioning with Chrome?

Answering myself: no. This PR is not needed for go2rtc to work with H265 for WebRTC in Chrome. It's already working now that 136 was pushed to stable.

@vampywiz17
Copy link

Chrome 136 is probably going to support H.265 in WebRTC by default. Is this PR needed for functioning with Chrome?

Answering myself: no. This PR is not needed for go2rtc to work with H265 for WebRTC in Chrome. It's already working now that 136 was pushed to stable.

these PR not add the support the HEVC, but add suppport that browser automatically use WebRTC and not MSE. But currently it not working... My stream are only MSE with automatic mode, only work WebRTC if i force it.

So it definately need it.

@felipecrs
Copy link
Contributor

Right, thanks for clarifying it.

Comment on lines +674 to +676
if (!videoCodecs) {
return false;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor indentation issue which I think can be better fixed this way:

Suggested change
if (!videoCodecs) {
return false;
}
if (!videoCodecs) return false;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy