-
Notifications
You must be signed in to change notification settings - Fork 665
Add support for H.265 codec verification #1644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Chrome 136 is probably going to support H.265 in WebRTC by default. Is this PR needed for functioning with Chrome? |
Answering myself: no. This PR is not needed for go2rtc to work with H265 for WebRTC in Chrome. It's already working now that 136 was pushed to stable. |
these PR not add the support the HEVC, but add suppport that browser automatically use WebRTC and not MSE. But currently it not working... My stream are only MSE with automatic mode, only work WebRTC if i force it. So it definately need it. |
Right, thanks for clarifying it. |
if (!videoCodecs) { | ||
return false; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor indentation issue which I think can be better fixed this way:
if (!videoCodecs) { | |
return false; | |
} | |
if (!videoCodecs) return false; |
This pull request includes updates to the
VideoRTC
class in thewww/video-rtc.js
file to enhance codec support checking. The most important changes are the addition of a new method to check for H.265 support and the modification of codec priority assignment logic.Enhancements to codec support checking:
www/video-rtc.js
: Added a new static methodisH265Supported
to check if H.265/HEVC codecs are supported by the browser.www/video-rtc.js
: Updated the condition for assigningmsePriority
for 'hvc1.' codecs to include a check using the newisH265Supported
method.