Skip to content

asc version global variables #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 30, 2021
Merged

Conversation

bnbarak
Copy link
Contributor

@bnbarak bnbarak commented Mar 28, 2021

  • I've read the contributing guidelines

What

Per #1708, I added global (magic?) variables for major, minor, and patch semantic versions. The version is coming from the the root package.json (either in the webpack step or in runtime).

ASC_VERSION_MAJOR;
ASC_VERSION_MINOR;
ASC_VERSION_PATCH;

Note

I usually use the npm package semver to parse semantic versioning. In this use case, I feel that this is simple enough that we should not add a dependency on semver. If we ever release beta/alpha/build number, then we should utilize semver.

Co-authored-by: Max Graey <maxgraey@gmail.com>
@bnbarak
Copy link
Contributor Author

bnbarak commented Mar 30, 2021

@MaxGraey Just wondering what is the merge process?

@dcodeIO dcodeIO merged commit ede042d into AssemblyScript:master Mar 30, 2021
@dcodeIO
Copy link
Member

dcodeIO commented Mar 30, 2021

Thank you! :)

@bnbarak bnbarak deleted the asc-version branch March 30, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy