[#3385] Align interceptor behavior for Aggregate Members #3404
+152
−64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add testing validating member-only interceptor support #3385
Add InterceptorChain to align with sample. This breaks the test #3385
Extract ChainedMessageHandlerInterceptorMember, as it's required in the ChildForwardingCommandMessageHandlingMember for reuse #3385
Adjust interceptor behavior for child entities. Instead of preemptively checking the matching interceptors, simply push all interceptors into a ChainedMessageHandlerInterceptorMember. Doing so, we ensure the InterceptorChain is present as a ThreadLocal, allowing the InterceptorChainParameterResolver to inject it on time. If there are no interceptors, use the NoMoreInterceptors instance. This shifts makes it so that child entities behave the same as the parent aggregate when it comes to interceptor behavior. #3385
Remove use of final modifier #3385
Fix undesired indenting change #3385
abuijze
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ChildForwardingCommandMessageHandlingMemberfollowed a different paradigm for deciding which Annotated Message Handler Interceptors to pick.More specifically, it checked if the interceptors match with the message that's being handled.
Although not inherently wrong, if somebody used the
InterceptorChainparameter, it would simply fail.This failure stems from the way we set the
InterceptorChainfor parameter resolution. Namely, on aThreadLocal.For this process to succeed, we first want to invoke the chain before validating if the message can be handled.
The component that ensure that (1) the
InterceptorChainis present on aThreadLocaland (2) invokes all interceptors and the final handler, is theChainedMessageHandlerInterceptorMember.Hence, the old behavior made it so that aggregates with aggregate members, with interceptors ONLY on those aggregate members, didn't have their interceptors invoked IF those included the
InterceptorChainparameter.To resolve this, I moved the
ChainedMessageHandlerInterceptorMemberout of theAnnotatedHandlerInspector.This allowed me to reuse the
ChainedMessageHandlerInterceptorMemberinside theChildForwardingCommandMessageHandlingMember.By doing so, I aligned the interceptor behavior for aggregate and child entities (also called aggregate members).
This resolves issue #3385.