Skip to content

fix: fix file path when running in ESM #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2023
Merged

fix: fix file path when running in ESM #10

merged 1 commit into from
Jun 19, 2023

Conversation

art049
Copy link
Member

@art049 art049 commented Jun 16, 2023 •
edited
Loading

Before:

[CodSpeed] running with @codspeed/tinybench v1.1.0
    ✔ Measured file:/home/arthur/Projects/arthur-node-test/tests/bench.mjs::test_recursive_fibo_10
    ✔ Measured file:/home/arthur/Projects/arthur-node-test/tests/bench.mjs::test_recursive_fibo_20
    ✔ Measured file:/home/arthur/Projects/arthur-node-test/tests/bench.mjs::test_recursive_cached_fibo_10
    ✔ Measured file:/home/arthur/Projects/arthur-node-test/tests/bench.mjs::test_recursive_cached_fibo_100
    ✔ Measured file:/home/arthur/Projects/arthur-node-test/tests/bench.mjs::test_recursive_cached_fibo_1000

After:

[CodSpeed] running with @codspeed/tinybench v1.1.0
    ✔ Measured tests/bench.mjs::test_recursive_fibo_10
    ✔ Measured tests/bench.mjs::test_recursive_fibo_20
    ✔ Measured tests/bench.mjs::test_recursive_cached_fibo_10
    ✔ Measured tests/bench.mjs::test_recursive_cached_fibo_20

@adriencaccia I'm gonna merge this now. But maybe we could add some tests to check this behavior. Do you now an easy way to run jest both in CJS & ESM ?

@codspeed-hq
Copy link

codspeed-hq bot commented Jun 16, 2023 •
edited
Loading

CodSpeed Performance Report

Merging #10 fix/esm-path (a2d0d88) will not alter performances.

Summary

🔥 0 improvements
❌ 0 regressions
✅ 4 untouched benchmarks

🆕 0 new benchmarks
⁉️ 0 dropped benchmarks

@adriencaccia
Copy link
Member

@adriencaccia I'm gonna merge this now. But maybe we could add some tests to check this behavior. Do you now an easy way to run jest both in CJS & ESM ?

This should do the trick https://jestjs.io/docs/ecmascript-modules

@art049 art049 merged commit a2d0d88 into main Jun 19, 2023
@art049 art049 deleted the fix/esm-path branch June 19, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@art049 @adriencaccia
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy