Skip to content

Update 403.html to be more consistent #3492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

momo3404
Copy link

Fixes issue here: portagenetwork#1029

  • Changed html page for Error 403 to be more consistent with other error html pages.

@aaronskiba
Copy link
Contributor

Hi @momo3404, thank you for this. 🙏

@momo3404
Copy link
Author

No worries! I'm not sure why Danger is failing. If it has something to do with the branch, I branched from DMPRoadmap's development branch in my fork and (my fork's dev branch had other changes I didn't want as part of this PR) and just made this one change in that branch (html-1029).

@aaronskiba
Copy link
Contributor

No worries! I'm not sure why Danger is failing. If it has something to do with the branch, I branched from DMPRoadmap's development branch in my fork and (my fork's dev branch had other changes I didn't want as part of this PR) and just made this one change in that branch (html-1029).

Yes, that is a Danger issue; nothing wrong on your end. https://github.com/portagenetwork is also forked off of DMPRoadmap and I always encounter the same when I submit a PR from there.

I just took a quick initial look; your PR is definitely an improvement, thank you again.

I had the issue marked on the forked repo (https://github.com/portagenetwork), and was going to suggest rebasing your branch and pointing the PR at theintegration branch of that repo. However, I think the same branding update might be needed here. I'll look into it, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy