Add field for timestamp #4895
Open
Add field for timestamp #4895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
2 tasks
b34d21b to
3ec7680
Compare
Signed-off-by: Erik Myhrberg <erimy268@student.liu.se> Signed-off-by: Antti Huovila <anthu456@student.liu.se>
3ec7680 to
3097d38
Compare
nscuro
reviewed
May 13, 2025
Comment on lines
+308
to
+316
| /** | ||
| * Convenience field which stores the timestamp of when the BOM was generated (from BOM metadata). | ||
| */ | ||
| @Persistent | ||
| @Index(name = "PROJECT_BOM_TIMESTAMP_IDX") | ||
| @Column(name = "BOM_TIMESTAMP", jdbcType = "BIGINT", allowsNull = "true") | ||
| @Schema(type = "string", format = "date-time", description = "Timestamp when the BOM was generated (from BOM metadata)") | ||
| @JsonInclude(JsonInclude.Include.NON_NULL) | ||
| private Date bomTimestamp; |
There was a problem hiding this comment.
I think conceptually this would belong to the Bom entity.
Bom is not currently surfaced on the UI, but it should be. Ideally, each project would have a list (i.e. timeline) of Boms that were imported to it. The data is there, it just needs exposure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a field for showing the timestamp for when an SBOM that has been uploaded to a project was originally generated. This shows the "age" of the SBOM, which is informative and is a fitting field to have in the Project/Overview window under "last bom import". My code fetches the timestamp from the metadata/timestamp section in a standard CycloneDX SBOM. I modified existing functionality to easily be able to do this as soon as a BOM is uploaded to a project.
Addressed Issue
Closes #2782
Additional Details
Link to original issue: #2782
Checklist
- [ ] This PR introduces changes to the database model, and I have added corresponding update logic- [ ] This PR introduces new or alters existing behavior, and I have updated the documentation accordingly