-
Notifications
You must be signed in to change notification settings - Fork 7
Update information about support for image and video capture #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
en/guide/configuration_file.md
Outdated
|
||
Key | Description | Default | ||
--- | --- | --- | ||
`width` | TBD | TBD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is waiting on #22
en/guide/configuration_file.md
Outdated
|
||
Example: | ||
``` | ||
[imgcap] | ||
location=~/Temp/ | ||
``` | ||
|
||
### [vidcap] {#vidcap} | ||
|
||
<!-- These specify the default values for video capture, that will eventually be over ridable by parameter settings from MAVLink --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lbegani My understanding is that all vidcap and imagecap keys all define default values for image/video capture that it should be possible to update via mavlink (ie QGC) once Dronecode/camera-manager#161 is done. Is that correct?
If so, I'll add a note about that at the top of these sections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, other than location
, everything else should be settable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much. I have updated. This is now ready for review :-)
@lbegani I had to merge this as I've been losing track of related changes I made. Can you scan it for correctness though? |
`width` | Width of the image to be captured in pixels. | Full width of camera frame for sensor type (i.e 1080P - 1920, 720P - 1280, etc.) | ||
`height` | Height of the image to be captured in pixels. | Full height of camera frame for sensor type (i.e 1080P - 1080, 720P - 720, etc). | ||
`format` | Image format (number). <br>Possible values:<ul><li>2 (Jpeg/<code>IMAGE_FILE_JPEG</code>)</li></ul>Notes:<ul><li>Currently only Jpeg is <a href="https://github.com/Dronecode/camera-streaming-daemon/issues/163">supported for image capture</a>.</li></ul> | 2 (JPEG). | ||
`location` | The local path with write permission where captured images will be saved (usually the system-standard "Temp" directory). The path should be accessible and writeable. | /tmp/ | ||
|
||
Example: | ||
``` | ||
[imgcap] | ||
location=~/Temp/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Example for other fields can be added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, done! b07e19d
Uh oh!
There was an error while loading. Please reload this page.