Skip to content

Update information about support for image and video capture #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2018
Merged

Update information about support for image and video capture #24

merged 4 commits into from
Apr 24, 2018

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Apr 19, 2018

  • Update imgcap section in config file docs
  • Update vidcap section in config file docs
  • Update overview doc to remove limitation/statements image/video storage not supported
  • Update overview doc to state limitation that defaults for image/video cannot be overwritten in camera definition file (linking to associated issue).

@hamishwillee hamishwillee requested a review from lbegani April 19, 2018 02:01

Key | Description | Default
--- | --- | ---
`width` | TBD | TBD
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is waiting on #22


Example:
```
[imgcap]
location=~/Temp/
```

### [vidcap] {#vidcap}

<!-- These specify the default values for video capture, that will eventually be over ridable by parameter settings from MAVLink -->
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lbegani My understanding is that all vidcap and imagecap keys all define default values for image/video capture that it should be possible to update via mavlink (ie QGC) once Dronecode/camera-manager#161 is done. Is that correct?

If so, I'll add a note about that at the top of these sections.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, other than location, everything else should be settable

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much. I have updated. This is now ready for review :-)

@hamishwillee hamishwillee merged commit f773c0f into Dronecode:master Apr 24, 2018
@hamishwillee
Copy link
Collaborator Author

@lbegani I had to merge this as I've been losing track of related changes I made. Can you scan it for correctness though?

@hamishwillee hamishwillee deleted the image_capture branch April 24, 2018 00:48
`width` | Width of the image to be captured in pixels. | Full width of camera frame for sensor type (i.e 1080P - 1920, 720P - 1280, etc.)
`height` | Height of the image to be captured in pixels. | Full height of camera frame for sensor type (i.e 1080P - 1080, 720P - 720, etc).
`format` | Image format (number). <br>Possible values:<ul><li>2 (Jpeg/<code>IMAGE_FILE_JPEG</code>)</li></ul>Notes:<ul><li>Currently only Jpeg is <a href="https://github.com/Dronecode/camera-streaming-daemon/issues/163">supported for image capture</a>.</li></ul> | 2 (JPEG).
`location` | The local path with write permission where captured images will be saved (usually the system-standard "Temp" directory). The path should be accessible and writeable. | /tmp/

Example:
```
[imgcap]
location=~/Temp/
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example for other fields can be added

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done! b07e19d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy