Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Firebase v9 #369

Merged
merged 101 commits into from
Aug 19, 2021
Merged

Support Firebase v9 #369

merged 101 commits into from
Aug 19, 2021

Conversation

jhuleatt
Copy link
Collaborator

@jhuleatt jhuleatt commented May 3, 2021 •
edited
Loading

Description

v9 of the Firebase JS SDK introduces a new modular SDK to allow for smaller bundle sizes (details). Feedback is welcome in discussion #402!

Todo List

  • Update deps: Firebase v9 and rxfire v6
  • Update ReactFire source to new modular SDK style
  • Update SDK handling (useFirestore, etc)
  • Add a provider for every SDK (<FirestoreProvider sdk={firestore} />, etc)
  • Add an async initializer for every SDK (useInitFirestore, etc)
  • Update non-suspense-mode example app
    • Initialize Firebase app
    • Auth
    • Firestore
    • Realtime Database
    • Remote Config
    • Storage
  • Update suspense-mode example app
  • Update/add tests
    • Firebase app
    • Auth
    • Firestore
    • Realtime Database
    • Storage
    • useSdk
  • Update docs
    • Regenerate reference docs
    • Update guides
    • Update README
    • Quickstart
    • v3 -> v4 upgrade guide

Out of scope for this PR, to be added later:

Code samples

See a sample in #402, and much more sample code in the modular-firebase branch.

fixes #388

@google-cla google-cla bot added the cla: yes label May 3, 2021
@jhuleatt jhuleatt changed the title Support Firebase v9 [WIP] Support Firebase v9 May 5, 2021
@jhuleatt jhuleatt marked this pull request as draft May 7, 2021 13:51
@jhuleatt jhuleatt mentioned this pull request Jun 10, 2021
Closed
@atanaskanchev
Copy link

@jhuleatt Hi, is it possible to cut-off RC4 please?

@jhuleatt
Copy link
Collaborator Author

jhuleatt commented Aug 6, 2021

it possible to cut-off RC4 please?

@atanaskanchev thanks for catching that we didn't release a canary for the latest commit, looks like I broke the build while I was trying to diagnose something else. A new canary (reactfire@4.0.0-exp.2b31a5a) just released, and the latest will continue to be available at npm i reactfire@exp.

@jhuleatt jhuleatt changed the title [WIP] Support Firebase v9 Support Firebase v9 Aug 18, 2021
@jhuleatt jhuleatt marked this pull request as ready for review August 18, 2021 19:39
@jhuleatt jhuleatt merged commit a2d2f1c into main Aug 19, 2021
@jhuleatt jhuleatt deleted the modular-firebase branch August 19, 2021 16:18
@akrawchyk
Copy link

this is awesome, thanks @jhuleatt!

@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jamesdaniels jamesdaniels jamesdaniels approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for modular firebase v9 SDK
5 participants
@jhuleatt @atanaskanchev @akrawchyk @jamesdaniels @justjish
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy