Visject larger input boxes #3540
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes Visject inputs uniform size of 50 pixels (instead of float3s being 20 pixels each etc). It also makes comparison nodes automatically expand to contain the input boxes instead of allowing them to overflow and potentially block the output node.
While not perfect, this is a huge improvement and makes using the node graphs less painful.
The only notable issue I could spot is that comparisons don't collapse back to their original size if both inputs are populated, indicating that the
SurfaceNode
'sReizeAuto()
for some reason does not ignore invisible children despite having a child visibility check.