Minor changes and updating Selene to be compatible with PyTorch 1.4.0 #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… bases ordering when using Selene-trained models vs. Lua-trained models
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #130, #133
What does this implement/fix? Explain your changes.
This is a work-in-progress PR to update the library after some breaking changes from the pytorch update to 1.4.0. I have not included the full set of updates yet, which will need to include pinning the version range for pytorch with which selene is compatible, as well as some other minor functionality improvements.
What testing did you do to verify the changes in this PR?
I will be testing all the main functions of Selene (training, evaluation, analyses - variant effect prediction, ISM, prediction) with an older and newer version of pytorch.