Skip to content

chore: api v2 notifications samples #9276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 24, 2024
Merged

chore: api v2 notifications samples #9276

merged 6 commits into from
Apr 24, 2024

Conversation

rafaelMurata
Copy link

Description

Fixes: https://buganizer.corp.google.com/issues/331816847

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@rafaelMurata rafaelMurata requested review from yoshi-approver and a team as code owners April 3, 2024 19:24
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Apr 3, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: securitycenter Issues related to the Security Command Center API. labels Apr 3, 2024
@rafaelMurata rafaelMurata force-pushed the notification-samples branch from 2119c0b to 376beeb Compare April 8, 2024 14:34
@kweinmeister kweinmeister added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 9, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 9, 2024
@rafaelMurata rafaelMurata force-pushed the notification-samples branch from 376beeb to 0bbf800 Compare April 11, 2024 14:52
@rsamborski rsamborski assigned Sita04 and unassigned kweinmeister Apr 16, 2024
@rsamborski rsamborski added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 16, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 16, 2024
@Sita04
Copy link
Contributor

Sita04 commented Apr 16, 2024

@rafaelMurata Error log for your reference:

[ERROR] vtwo.NotificationIT Time elapsed: 0.532 s <<< ERROR! com.google.api.gax.rpc.PermissionDeniedException: io.grpc.StatusRuntimeException: PERMISSION_DENIED: PubSub topic projects/project-a-id/topics/test-topic does not exist. Caused by: io.grpc.StatusRuntimeException: PERMISSION_DENIED: PubSub topic projects/project-a-id/topics/test-topic does not exist.

@rafaelMurata rafaelMurata force-pushed the notification-samples branch from 91c2e03 to a8dfca3 Compare April 18, 2024 18:39
@Sita04 Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 19, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 19, 2024
@rafaelMurata rafaelMurata reopened this Apr 22, 2024
@Sita04 Sita04 merged commit 4e07423 into GoogleCloudPlatform:main Apr 24, 2024
8 checks passed
Sita04
Sita04 reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@Sita04 Sita04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the snippets! LGTM

rafaelMurata pushed a commit to rafaelMurata/java-docs-samples that referenced this pull request May 7, 2024
chore: api v2 notifications samples (GoogleCloudPlatform#9276)
3a0affa 
* chore: api v2 notifications samples

* add checkstyle

* add InterruptedException in unit-test

* update license headers

* improve readability

* fix topic error
rafaelMurata pushed a commit to rafaelMurata/java-docs-samples that referenced this pull request May 27, 2024
chore: api v2 notifications samples (GoogleCloudPlatform#9276)
1896333 
* chore: api v2 notifications samples

* add checkstyle

* add InterruptedException in unit-test

* update license headers

* improve readability

* fix topic error
@rafaelMurata rafaelMurata deleted the notification-samples branch June 12, 2024 13:04
@hegemonic hegemonic mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sita04 Sita04 Sita04 left review comments

@kweinmeister kweinmeister kweinmeister approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

@Sita04 Sita04

Labels
api: securitycenter Issues related to the Security Command Center API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rafaelMurata @Sita04 @kweinmeister @rsamborski @kokoro-team
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy