Skip to content

Contributing Equipment #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 1, 2025
Merged

Conversation

CPBridge
Copy link
Collaborator

@CPBridge CPBridge commented Jun 2, 2025

DICOM's Contributing Equipment Sequence is an optional general mechanism allows an object creator to list various pieces of equipment that have contributed to the creation of an instance. Currently highdicom does not populate this sequence in objects it creates. This PR adds support for the Contributing Equipment Sequence.

A new ContributingEquipment class encapsulates an item of the Contributing Equipment Sequence. All IODs now accept an argument to add items to this sequence. By default, highdicom will add an item for the initial image creation, and a further item for highdicom itself describing the instance creation.

@CPBridge CPBridge added the enhancement New feature or request label Jun 2, 2025
@CPBridge CPBridge merged commit 4202a63 into v0.26.0dev Jul 1, 2025
8 checks passed
@CPBridge CPBridge deleted the feature/contributing_equipment branch July 1, 2025 03:15
CPBridge added a commit that referenced this pull request Jul 2, 2025
* Add option to use extended offset table (#354)

* Simplify decode_frame to use pydicom deocder directly (#353)

* Improvements to spatial calculations (#357)

* Add debug logging to spatial calculations

* Add perpencicular_tol as a parameter

* Improvements to volume docs

* Fix line length

* Improve logic to match segmentation frames to source images (#361)

* Add debug logging to spatial calculations

* Add perpencicular_tol as a parameter

* Improvements to volume docs

* Fix line length

* Refactor seg spatial metadata preparation

* Recover existing behavior after refactor

* WIP

* Complete implementation of matching; move generic parts to Image class

* Add volume reference tests

* Improve test comments

* Linterfixes

* Minor fixes

* Include further_source_images in plane matching

* Allow references to multiple frames on creation and parsing

* Add tests

* Lint

* Relax requirement for distinct dimensions

* Spell fixes

* Contributing Equipment (#356)

* Implement ContributingEquipment

* Add base_content file

* Remove unneeded import

* Refactor to _add_contributing_equipment method

* Version bump to 0.26.0

* "Usablility" improvements for working with volumes and segmentations (#367)

* Add affine conversion to volume constructors; add match_orientation

* Add ITK and NIfTI conversion docs

* Add pydicom and highdicom docs page

* Add missing docs page

* Rewrite of segmentation pixel array docstring

* lint

* Fix spelling

* Another spell fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy