-
Notifications
You must be signed in to change notification settings - Fork 20
New Feature: add new APIs to leetcode.cn and leecode.com & fix some errors #105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Feature: add new APIs to leetcode.cn and leecode.com & fix some errors #105
Conversation
- fix the error in the example for `leetcode.submissions` api
🦋 Changeset detectedLatest commit: 0c58c96 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sorry, I forgot to add the |
900d28b
to
381236f
Compare
I haven't modified any cache-related configurations. Can you rerun the pipeline? |
…nDetail interface
…clude submission ID
…n status and difficulty filters
…er progress with filters
submission_detail
API to leetcode.cn endpointThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 9 out of 13 changed files in this pull request and generated no comments.
Files not reviewed (4)
- src/graphql/leetcode-cn/submission-detail.graphql: Language not supported
- src/graphql/leetcode-cn/user-problem-submissions.graphql: Language not supported
- src/graphql/leetcode-cn/user-progress-questions.graphql: Language not supported
- src/graphql/submission-detail.graphql: Language not supported
Comments suppressed due to low confidence (2)
src/leetcode.ts:205
- The previous version used a rate limiter with explicit lock and unlock calls, but these have been removed. Please confirm that the GraphQL method now handles rate limiting appropriately to prevent potential unbounded concurrent requests.
return data.submissionDetails as SubmissionDetail;
src/leetcode-types.ts:266
- Changing 'runtime_distribution' from an array to a string may cause confusion if downstream code expects an array of values. Consider clarifying the new type (for example, renaming it to 'runtimeDistributionJSON' or adding documentation) to ensure proper handling.
runtimeDistribution: string;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that .changeset/curvy-planets-pay.md
is already covered by .changeset/warm-lobsters-act.md
.
Since it's a major update with breaking changes, I think it's better to mention the breaking changes in the changeset.
Other changes LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM!
lang
andstatus
parameters to user's submissions querysubmission_detail
interface of the leetcode.com to fix API errorsuser_progress_questions
method to retrieve user progress with filters to the leetcode.com