Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OrJanusPredicateTest.java #4756

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

Rian-Ismael
Copy link
Contributor

Improves the readability of the test. The assertions are clearer and include descriptive messages, making it easier to identify which assertion fails. This enhances code maintainability, understanding and debugging efficiency.


Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?

Copy link

linux-foundation-easycla bot commented Jan 30, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Improves the readability of the test. The assertions are clearer and include descriptive messages, making it easier to identify which assertion fails. This enhances code maintainability, understanding and debugging efficiency.

Signed-off-by: Rian-Ismael <106334437+Rian-Ismael@users.noreply.github.com>
Copy link
Member

@porunov porunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rian-Ismael
Copy link
Contributor Author

LGTM
Hello, @porunov. Errors are still occurring during the checking process. I tried to build it again, but the errors persist. Could you kindly take a look at it?

@porunov
Copy link
Member

porunov commented Feb 11, 2025

Looks like flaky tests. I just restarted those failing tests

@porunov porunov added this to the 1.2.0 milestone Feb 12, 2025
@porunov
Copy link
Member

porunov commented Feb 12, 2025

Merging by following lazy consensus

@porunov porunov merged commit 5ee7151 into JanusGraph:master Feb 12, 2025
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy