-
Notifications
You must be signed in to change notification settings - Fork 36
Add lin_nnzj
and nln_nnzj
and docstrings for functions
#500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@amontoison please review the changes made here |
@arnavk23 I will review the PR asap. |
CI failures are related. |
@tmigot can you review the changes made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have to change
https://github.com/JuliaSmoothOptimizers/NLPModels.jl/blob/main/test/nlp/show.jl
and maybe this
https://github.com/JuliaSmoothOptimizers/NLPModels.jl/blob/main/test/nls/show.jl
so that the tests pass.
Can you also edit the README.md in this PR?
Thank you!
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
Co-authored-by: Tangi Migot <tangi.migot@gmail.com>
@tmigot I have passed both for SimpleNLPModel but for Generic even when the showed and the expected are the same, it is throwing an error for both test/nlp/show.jl and test/nls/show.jl |
@tmigot this is what is coming as I was saying above -
|
@amontoison @tmigot I have checked it on my system now properly, it works. It should be passing all the tests now. |
@amontoison @tmigot It passes all tests except the breakage/upload one |
Thanks @arnavk23 ! |
This PR adds the
lin_nnzj
andnln_nnzj
fields to the output of theshow
method forAbstractNLPModelMeta
and documents the purpose and usage of the scaling-related functions exported in the NLPModels API:varscale
,lagscale
, andconscale
.Closes #485
Closes #413