Implement donation dialog #3056
Conversation
* Implement donation dialog * lint * change layout * update text, add title * update submodule, fix mobile * remove "hide permanently" * update text, change button color, use html for message * A few fixes to the donation dialog. (#3051) * fix close button * color adjustments --------- Co-authored-by: Dessalines <dessalines@users.noreply.github.com>
|
Yep that's correct, I'll get it merged into my dev branch. |
| __html: sanitizeHtml( | ||
| I18NextService.i18n.t("donation_dialog_message"), | ||
| ), | ||
| }} |
There was a problem hiding this comment.
Should get rid of raw html here similar to joinlemmy pr
There was a problem hiding this comment.
I see that donation_dialog_message has html in it. It'd be better to remove that entirely and either:
- Split it into 2 strings, IE
donation_dialog_message_1anddonation_dialog_message_2 - Replace the
<br>s with<1>, as the i18next react uses.
The first is probably better and much easier. Really html shouldn't be used for line breaks, but only for within-sentence formatting where you need to use links, italics, etc.
|
CI is failing because of changes in js-client. |
| @@ -60,7 +60,7 @@ | |||
| "inferno-router": "^8.2.3", | |||
| "inferno-server": "^9.0.0", | |||
| "jwt-decode": "^4.0.0", | |||
| "lemmy-js-client": "0.20.0-alpha.17", | |||
| "lemmy-js-client": "1.0.0-alpha.0", | |||
There was a problem hiding this comment.
Not sure that we should do this yet, and compeletely break main. Probably safer to do PRs to my 1.0 dev branch until we get everything compiling.
There was a problem hiding this comment.
Agree, otherwise it will be impossible to work on lemmy-ui until that PR is merged.
Add donation dialog to main branch (from #3034).
Translations: LemmyNet/lemmy-translations#163
JS client: LemmyNet/lemmy-js-client#547
Currently throws a lot of compile errors, probably requires #2985 to be merged first.