Update actions to minimize node use. #933
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a conditional NODE_OPTIONS setting to the GitHub Actions workflow to limit Node.js memory usage for the gt label, aiming to reduce overall node consumption.
- Add
NODE_OPTIONSenvironment variable only whenmatrix.lblisgt.
Comments suppressed due to low confidence (1)
.github/workflows/test.yml:104
- [nitpick] The inline conditional for
NODE_OPTIONScan be hard to read. Consider using a dedicatedif: matrix.lbl == 'gt'at the job or step level (with its ownenv:block) to set this variable only for the GT job, which improves clarity and maintainability.
NODE_OPTIONS: ${{ matrix.lbl == 'gt' && '--max-old-space-size=2048' || '' }}
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #933 +/- ##
=======================================
Coverage 43.71% 43.71%
=======================================
Files 68 68
Lines 18360 18360
Branches 2292 2292
=======================================
Hits 8026 8026
Misses 8945 8945
Partials 1389 1389 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
User description
Trying to make phoenix work!
Update: Shockingly challenging! Almost there.
TODO:
misc/directory in version control.Closes #932
PR Type
Other
Description