-
Notifications
You must be signed in to change notification settings - Fork 111
Delete cuTensor #965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete cuTensor #965
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes cuTensor support from MFC by eliminating all cuTensor-related code, build configurations, and conditional compilation blocks. The changes simplify the WENO implementation by removing GPU-accelerated tensor reshape operations and their associated fallback logic.
Key changes:
- Removal of cuTensor conditional compilation blocks and reshape operations in WENO routines
- Elimination of cuTensor build system integration and compiler checks
- Simplification of control flow by removing cuTensor-specific code paths
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/simulation/m_weno.fpp | Removes cuTensor conditional blocks and GPU tensor reshape operations for y and z directions |
src/simulation/m_checker.fpp | Eliminates cuTensor compiler availability check |
CMakeLists.txt | Removes cuTensor library detection, linking, and build configuration |
Comments suppressed due to low confidence (1)
src/simulation/m_weno.fpp:1165
- [nitpick] This appears to be an unintentional blank line addition. Consider removing it to maintain consistent spacing in the code.
do k = is1_weno%beg - weno_polyn, is1_weno%end + weno_polyn
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨No code suggestions found for the PR. |
I think this is a search of the master branch on my fork? These are all of the lines that I removed. |
nvm. will merge when tests pass (which i'm sure they will) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #965 +/- ##
==========================================
- Coverage 44.08% 44.06% -0.02%
==========================================
Files 69 69
Lines 19573 19568 -5
Branches 2428 2430 +2
==========================================
- Hits 8628 8623 -5
Misses 9444 9444
Partials 1501 1501 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
User description
Description
Delete cuTensor and the code for
riemann_flat
andweno_flat
that hasn't existed for years.Type of change
Scope
PR Type
Other
Description
Remove cuTensor library support from MFC
Delete compiler checks for cuTensor availability
Remove cuTensor-based tensor reshaping operations
Simplify WENO scheme to use standard GPU loops
Diagram Walkthrough
File Walkthrough
m_checker.fpp
Remove cuTensor compiler validation
src/simulation/m_checker.fpp
m_weno.fpp
Replace cuTensor with standard GPU loops
src/simulation/m_weno.fpp
CMakeLists.txt
Remove cuTensor build configuration
CMakeLists.txt