Fix: Block auto reconnect if connection duration less than 5 seconds. #7952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…less than 5 seconds.
SlySven
reviewed
Jul 13, 2025
There was a problem hiding this comment.
Looks reasonable - except that I've just spotted that ALL the reason strings are present on the main console and should be translated for the end-users locale - use tr(...) instead of qsl(...) around them. The detection of the specific check for unsupported "Secure connections" ALSO needs checking to see whether Qt provides a translated text in the QSslSocket::errorString() output or it is ALWAYS in English - which will modify handling THAT case.
vadi2
pushed a commit
that referenced
this pull request
Jul 21, 2025
#7957) #### Brief overview of PR changes/additions Change the qsl("connection failure messages") that we stumbled upon in PR #7952 to tr("connection failure messages"). Additionally, replace the string matching for a failed secure connection (which didn't seem to work) with a check against the SSL handshake fail error enum (QAbstractSocket::SocketError(13)) #### Motivation for adding to Mudlet Tidying up this little bit of code to the more modern internationalized Mudlet standard. #### Other info (issues closed, discussion etc) @SlySven, if you could test this I would appreciate it. The SSL handshake error catching has worked in all failure modes I've managed to test, but I haven't managed to duplicate the errors I saw you produce on Discord.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief overview of PR changes/additions
Use cTelnet's mConnectionTimer to track whether the client was connected to the server for under 5 seconds. If so, auto-reconnect is blocked.
Also the disconnect message is modified to clarify that the disconnection reason was for "Connection/login attempt rejected by server".
Motivation for adding to Mudlet
Hopefully an approximate fix for the issues surrounding failed auto-logins / Mudlet spamming servers with automatic reconnects.
Other info (issues closed, discussion etc)
Tested to prevent login-loops for mistaken passwords, but succeeds in reconnecting for disconnection events during a normal playing session. Also this doesn't prevent echoing connection errors via e.g. failed SSL authentication.
I consider this an elegant solution for differentiating between servers rejecting a client's connection attempt and disconnecting while playing, but I would understand if Mudlet would prefer to more explicitly track whether a login attempt failed etc.
(Potentially) Fixes: #7584