Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ww3 hycom #926

Draft
wants to merge 169 commits into
base: develop
Choose a base branch
from
Draft

Ww3 hycom #926

wants to merge 169 commits into from

Conversation

heloisemichaud
Copy link

@heloisemichaud heloisemichaud commented Mar 2, 2023 •
edited
Loading

Pull Request Summary

adaptation to the hycom coupling

Description

Issue(s) addressed

Commit Message

Check list

Testing

  • How were these changes tested?
  • Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
  • Have the matrix regression tests been run (if yes, please note HPC and compiler)?
  • Please indicate the expected changes in the regression test output, (Note the list of known non-identical tests.)
  • Please provide the summary output of matrix.comp (matrix.Diff.txt, matrixCompFull.txt and matrixCompSummary.txt):

aronroland added 30 commits May 19, 2022 09:08
@aronroland
ww3_wise: add my comp and link
09164b5
@aronroland
ww3_wise: add my comp and link
59638f6
@aronroland
ww3_wise: comp and link datarmo
9fd1a47
@aronroland
ww3_wise: group velocities and new limiter ...
bb00127
@aronroland
ww3_wise: improve speed of computation
e5d2d9d
@aronroland
ww3_wise: further optimization level
826ab06
@aronroland
ww3_wise: some more cleaning
d843168
@aronroland
ww3_wise: more on performance
29139ac
@aronroland
Merge branch 'ww3_wise' of https://github.com/erdc/WW3 into ww3_wise
ff51b11 
Conflicts:
	model/src/w3profsmd_pdlib.F90
@aronroland
ww3_wise: more on performance
a586cc9
@aronroland
ww3_wise: ... memory ...
89e2a1c
@aronroland
ww3_wise: fix more memcheck issues
78ee80f
@aronroland
ww3_wise: and more on memcheck
4931557
@aronroland
ww3_wise: more on memcheck and others
54b301a
@aronroland
ww3_wise: more on debugging ...
193496b
@aronroland
ww3_wise: more on limiters ...
1b1c04c
@aronroland
Merge branch 'develop' into ww3_wise
7924004
@aronroland
ww3_wise: merge from WISE
ed82af9
@aronroland
ww3_wise: fix typo and syntax error
6b22bca
@aronroland
ww3_wise: testing load imbalance
a9c17c4
@aronroland
ww3_wise: update wave reflection and extend for implicit
e388055
@aronroland
ww3_wise: commit missing use part for reflection
b6ed65c
@aronroland
Merge branch 'develop' into ww3_wise
5dcf76d
@aronroland
ww3_wise: conflicts
bb1ffd0
@aronroland
finished merge with develop
a6d7dfe
@aronroland
ww3_wise: more on the merge ...
fba00ba
@aronroland
ww3_wise: next part of consolodiation
8f9ba92
@aronroland
ww3_wise: merge wave_setup
b60e6cc
@aronroland
ww3_wise: more on setup
e79c3aa
@aronroland
ww3_wise: 2nd part
70277b9
aronroland and others added 17 commits February 27, 2023 21:46
@aronroland
ww3_wise_merge_develop: edit namelist based on jessica input
a32ca06
@aronroland
ww3_wise_merge_develop: fix issues following tyler
e29a9c0
@aronroland
ww3_wise_merge_develop: some more work on the namelist comments
d8ada73
@aronroland
ww3_wise_merge_develop: working on the namelist
533ac5f
@aliabdolali
Merge branch 'NOAA-EMC:develop' into ww3_wise_merge_develop
8643a93
@aronroland
ww3_wise_merge_develop: clean and add missing pragma
04b4451
@aronroland
Merge branch 'ww3_wise_merge_develop' of https://github.com/erdc/WW3 …
1b6c95e 
…into ww3_wise_merge_develop

Conflicts:
	model/src/w3srcemd.F90
@aronroland
ww3_wise_merge_develop: cleaning and namelist
f40ef82
@aronroland
Merge branch 'ww3_wise_merge_develop' of https://github.com/erdc/WW3 …
ef22a77 
…into ww3_wise_merge_develop
@aronroland
Merge branch 'ww3_wise_merge_develop' of https://github.com/erdc/WW3 …
d9a5737 
…into ww3_wise_merge_develop
@thesser1
adding boers case regtest ww3_tp2.19
dd60dcb
@aronroland
ww3_wise_merge_develop: add explanation of unst namelist in the inp f…
3cd9ca2 
…ile ...
@thesser1
cleaning up regtest 2.19
962900a
merge develop
0ccb4e9
@aliabdolali
Update switch_PDLIB
2fa2b76
@aronroland
Merge branch 'ww3_wise_merge_develop' of https://github.com/erdc/WW3 …
3757cd7 
…into ww3_wise_merge_develop
@aronroland
ww3_hycom: start working on hycom part
0bff17e
@JessicaMeixner-NOAA
Copy link
Collaborator

Hi @heloisemichaud Thanks for this PR. This PR seems to be either build on or be a repeat of PR #888. Can you clarify? Also, we will need you to fill out the entire PR template.

@aronroland
Copy link
Collaborator

aronroland commented Mar 2, 2023 via email

@JessicaMeixner-NOAA
Copy link
Collaborator

@aronroland Happy to help! @heloisemichaud - just reply back with any questions you have - we're happy you've made a PR!

@heloisemichaud heloisemichaud marked this pull request as draft March 2, 2023 13:27
@aronroland
Copy link
Collaborator

just some clarification this will be a addition to the OASIS coupler, which is only dedicated when ww3 is coupled to hycom, whereas #888 is more general. Heloise and me will do some more training tomorrow and hopefully finish the pull request. Thanks for your understanding.

@MatthewMasarik-NOAA
Copy link
Collaborator

Hello @aronroland, I wanted to check in to see if there is anything needed from us for this PR? There is no rush of course if you continue to work on it, I just wanted to touch base on it.

@aronroland
Copy link
Collaborator

@MatthewMasarik-NOAA i will discuss with Heloise and provide some time line, this should be closed pretty soon. Thanks for pointing this out.

@MatthewMasarik-NOAA
Copy link
Collaborator

Thanks for the update, @aronroland. Please reach out if we can be of any help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@heloisemichaud @JessicaMeixner-NOAA @aronroland @MatthewMasarik-NOAA @aliabdolali @thesser1
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy