Apply 'Force SSL' and 'Enable Websockets' to full host definition #1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes issues with these settings not applying to custom locations defined under hosts.
This fixes issues with these settings not applying to custom locations defined under hosts.
|
Docker Image for build 1 is available on DockerHub as |
|
Docker Image for build 3 is available on DockerHub as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template options for these two options have been moved out of the root location block, and into the server block, in order for them to apply to custom locations set up via the proxy manager. This matches up with default expectations of how these toggle options work (as they are defined in the frontend host definition rather than the location).
If override behaviour is desired, these options can still be overridden by the existing "custom options" support offered.