added regex for elasticsearch #1078
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkid15r
reviewed
Jun 8, 2025
nettacker/modules/scan/port.yaml
Outdated
| @@ -1042,6 +1042,10 @@ payloads: | |||
| regex: "HTTPStatus.BAD_REQUEST|HTTP\\/[\\d.]+\\s+[\\d]+|Server: |Content-Length: \\d+|Content-Type: |Access-Control-Request-Headers: |Forwarded: |Proxy-Authorization: |User-Agent: |X-Forwarded-Host: |Content-MD5: |Access-Control-Request-Method: |Accept-Language: " | |||
| reverse: false | |||
|
|
|||
| elasticsearch: | |||
There was a problem hiding this comment.
Could you move it above ftp?
There was a problem hiding this comment.
I did that but I don't think its such a good idea, because I think it cascades down the services list in port.yaml and for elasticsearch services, the returned banner can be identified under http as well, so we might end up getting http instead of elasticsearch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Added regex matches for elasticsearch.
Type of change
Checklist
make pre-commit, it didn't generate any changesmake test, all tests passed locally