feature: don't list duplicate java runtimes #1545
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now I think about it, this change in functionality should probably be controlled by a 'Include symbolic links' checkbox or something... Since there is still a legitimate reason that people might want to use a symbolic link instead of using the canonical path of the runtime... Although, I think that generally specifying the canonical path to the runtime is what you would want to do. |
a58e1aa to
7bc729d
Compare
Signed-off-by: Lenny McLennington <lenny@sneed.church>
06de241 to
94cd75e
Compare
|
Adding the setting is easy but the only question is should it be a default; I'd argue the answer is that the default should not include symlinks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the same java runtime with a different symlink path being shown multiple times... On Arch Linux you can get like 4x duplicates of the same java runtime due to symlinks, with this change it only shows one entry per actual runtime in the paths searched, using the canonical path of that runtime.