Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exe signing with third party signing for WiX engine #23878

Merged
merged 3 commits into from
May 31, 2024

Conversation

adityapatwardhan
Copy link
Member

@adityapatwardhan adityapatwardhan commented May 31, 2024

PR Summary

Make sure we sign the Wix engine as well.

PR Context

PR Checklist

Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

offline comments

@TravisEz13 TravisEz13 self-assigned this May 31, 2024
@TravisEz13 TravisEz13 added CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log Backport-7.2.x-Consider BackPort-7.4.x-Consider labels May 31, 2024
Copy link
Member

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

live review

@TravisEz13 TravisEz13 enabled auto-merge (squash) May 31, 2024 17:01
@TravisEz13 TravisEz13 merged commit 51b8e5d into PowerShell:master May 31, 2024
12 checks passed
Copy link
Contributor

microsoft-github-policy-service bot commented May 31, 2024

📣 Hey @adityapatwardhan, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

@adityapatwardhan
Copy link
Member Author

It seems it was not correctly backported.. Backport again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport-7.2.x-Done BackPort-7.4.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy