-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Hyper-V Remoting when using remoting import #24032
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
When on a Windows version that cannot load the Hyper-V module the State property will be of the string type. This change ensures that PowerShell can still parse this value to the VMState type as expected when the module was loaded natively. This should allow PSRemoting cmdlets that call Get-VM to properly get the VM State property.
microsoft-github-policy-service
bot
added
the
Review - Needed
The PR is being reviewed
label
Jul 17, 2024
daxian-dbw
requested changes
Jul 18, 2024
src/System.Management.Automation/engine/remoting/commands/PSRemotingCmdlet.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/remoting/commands/PSRemotingCmdlet.cs
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
Waiting on Author
The PR was reviewed and requires changes or comments from the author before being accept
and removed
Review - Needed
The PR is being reviewed
Waiting on Author
The PR was reviewed and requires changes or comments from the author before being accept
labels
Jul 18, 2024
daxian-dbw
reviewed
Jul 22, 2024
src/System.Management.Automation/engine/remoting/commands/PSRemotingCmdlet.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/remoting/commands/PSRemotingCmdlet.cs
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
the
Review - Needed
The PR is being reviewed
label
Jul 30, 2024
daxian-dbw
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
daxian-dbw
added
CL-General
Indicates that a PR should be marked as a general cmdlet change in the Change Log
and removed
Review - Needed
The PR is being reviewed
labels
Aug 1, 2024
Thanks for the review and fixing up that indentation @daxian-dbw! |
chrisdent-de
pushed a commit
to chrisdent-de/PowerShell
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
When on a Windows version that cannot load the Hyper-V module the State property will be of the string type. This change ensures that PowerShell can still parse this value to the VMState type as expected when the module was loaded natively. This should allow PSRemoting cmdlets that call Get-VM to properly get the VM State property.
PR Context
Fixes: #24014
I don't have a Server 2016 host to test against but it seems like the only other props used from
Get-VM
are aString
andGuid
types which should work without any issues in an implicitly remoted module import.PR Checklist
.h
,.cpp
,.cs
,.ps1
and.psm1
files have the correct copyright headerWIP:
or[ WIP ]
to the beginning of the title (theWIP
bot will keep its status check atPending
while the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).