Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/v7.2] chore: Refactor Nuget package source creation to use New-NugetPackageSource function #24397

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

TravisEz13
Copy link
Member

Backport #24104

This pull request includes changes to improve the handling of NuGet package sources in the pipeline configuration and build scripts. The modifications introduce a new NugetPackageSource class and simplify the creation of NuGet configuration files.

Improvements to NuGet package handling:

  • .pipelines/templates/insert-nuget-config-azfeed.yml: Replaced direct usage of New-NugetConfigFile with a new New-NugetPackageSource function to create a NugetPackageSource object before passing it to New-NugetConfigFile. [1] [2]
  • build.psm1: Introduced a new NugetPackageSource class and the New-NugetPackageSource function to encapsulate NuGet package source details, and updated the New-NugetConfigFile function to accept a NugetPackageSource object.

Copy link
Member Author

@TravisEz13 TravisEz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Oct 8, 2024
@TravisEz13 TravisEz13 merged commit fc3f09b into PowerShell:release/v7.2 Oct 8, 2024
32 of 34 checks passed
Copy link
Contributor

microsoft-github-policy-service bot commented Oct 8, 2024

📣 Hey @TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy