Skip to content

Fix RunspacePool, RunspacePoolInternal and RemoteRunspacePoolInternal IDisposable implementation #24720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

xtqqczze
Copy link
Contributor

@xtqqczze xtqqczze commented Dec 29, 2024

  • Implement IDisposable in System.Management.Automation.Runspaces.Internal.RunspacePoolInternal
  • Seal System.Management.Automation.Runspaces.Internal.RemoteRunspacePoolInternal type and remove public Dispose method .

@xtqqczze xtqqczze closed this Dec 29, 2024
@xtqqczze xtqqczze reopened this Dec 29, 2024
@xtqqczze xtqqczze marked this pull request as ready for review December 30, 2024 00:53
@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Jan 6, 2025
…oolInternal`

* Seal internal `System.Management.Automation.Runspaces.Internal.RemoteRunspacePoolInternal` class.
* Implement `IDisposable` in base class.
@xtqqczze xtqqczze force-pushed the seal-System.Management.Automation.Runspaces.Internal branch from 1e3bf57 to ecc4077 Compare January 31, 2025 19:00
@xtqqczze xtqqczze changed the title Seal System.Management.Automation.Runspaces.Internal.RemoteRunspacePoolInternal Fix RunspacePoolInternal IDisposable implementation Jan 31, 2025
@xtqqczze
Copy link
Contributor Author

/azp run

Copy link

Commenter does not have sufficient privileges for PR 24720 in repo PowerShell/PowerShell

@xtqqczze
Copy link
Contributor Author

@iSazonov could you run azure pipelines?

@iSazonov iSazonov closed this Feb 1, 2025
@iSazonov iSazonov reopened this Feb 1, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Review - Needed The PR is being reviewed label Feb 1, 2025
@iSazonov

This comment was marked as outdated.

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@xtqqczze
Copy link
Contributor Author

xtqqczze commented Feb 1, 2025

@iSazonov could you reapprove changes?

@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Feb 9, 2025
@iSazonov
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Review - Needed The PR is being reviewed label Feb 10, 2025
@iSazonov
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Feb 10, 2025
@iSazonov iSazonov self-assigned this Feb 10, 2025
@iSazonov iSazonov changed the title Fix RunspacePoolInternal IDisposable implementation Fix RunspacePool, RunspacePoolInternal and RemoteRunspacePoolInternal IDisposable implementation Feb 10, 2025
@iSazonov iSazonov merged commit 57bdd9c into PowerShell:master Feb 10, 2025
39 of 41 checks passed
Copy link
Contributor

microsoft-github-policy-service bot commented Feb 10, 2025

📣 Hey @xtqqczze, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy