-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Fix RunspacePool
, RunspacePoolInternal
and RemoteRunspacePoolInternal
IDisposable
implementation
#24720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
iSazonov
merged 4 commits into
PowerShell:master
from
xtqqczze:seal-System.Management.Automation.Runspaces.Internal
Feb 10, 2025
Merged
Fix RunspacePool
, RunspacePoolInternal
and RemoteRunspacePoolInternal
IDisposable
implementation
#24720
iSazonov
merged 4 commits into
PowerShell:master
from
xtqqczze:seal-System.Management.Automation.Runspaces.Internal
Feb 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oolInternal` * Seal internal `System.Management.Automation.Runspaces.Internal.RemoteRunspacePoolInternal` class. * Implement `IDisposable` in base class.
1e3bf57
to
ecc4077
Compare
System.Management.Automation.Runspaces.Internal.RemoteRunspacePoolInternal
RunspacePoolInternal
IDisposable
implementation
/azp run |
Commenter does not have sufficient privileges for PR 24720 in repo PowerShell/PowerShell |
@iSazonov could you run azure pipelines? |
This comment was marked as outdated.
This comment was marked as outdated.
Azure Pipelines successfully started running 3 pipeline(s). |
iSazonov
approved these changes
Feb 1, 2025
@iSazonov could you reapprove changes? |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 2 pipeline(s). |
RunspacePoolInternal
IDisposable
implementationRunspacePool
, RunspacePoolInternal
and RemoteRunspacePoolInternal
IDisposable
implementation
Contributor
📣 Hey @xtqqczze, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CL-CodeCleanup
Indicates that a PR should be marked as a Code Cleanup change in the Change Log
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDisposable
inSystem.Management.Automation.Runspaces.Internal.RunspacePoolInternal
System.Management.Automation.Runspaces.Internal.RemoteRunspacePoolInternal
type and remove publicDispose
method .